New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gha: dragonball: Enable, but do not run, cri-containerd, stability, and devmapper tests #8570
Merged
fidencio
merged 3 commits into
kata-containers:main
from
fidencio:topic/gha-dragonball-enable-some-tests-but-do-not-run-them-yet
Dec 5, 2023
Merged
gha: dragonball: Enable, but do not run, cri-containerd, stability, and devmapper tests #8570
fidencio
merged 3 commits into
kata-containers:main
from
fidencio:topic/gha-dragonball-enable-some-tests-but-do-not-run-them-yet
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
studychao
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fidencio
Apokleos
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @fidencio LGTM!
/test |
fidencio
force-pushed
the
topic/gha-dragonball-enable-some-tests-but-do-not-run-them-yet
branch
from
December 5, 2023 09:45
e7237b2
to
dbec428
Compare
/test |
This will make the life easier for dragonball developers to properly enable the tests once the tests are ready. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
This will make the life easier for dragonball developers to properly enable the tests once the tests are ready. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
This will make the life easier for dragonball developers to properly enable the tests once the tests are ready. Fixes: kata-containers#8569 Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
fidencio
force-pushed
the
topic/gha-dragonball-enable-some-tests-but-do-not-run-them-yet
branch
from
December 5, 2023 14:29
dbec428
to
05ce52d
Compare
GabyCT
approved these changes
Dec 5, 2023
/test |
fidencio
added a commit
to fidencio/kata-containers
that referenced
this pull request
Dec 29, 2023
We're using a QEMU based on v8.1.0, which should already include all the needed patches for SEV / SNP, with the patches for TDX atop of that. By doing this, later on, we'll be able to stop building the specific QEMU TDX experimental and QEMU SNP experimental targets. Fixes: kata-containers#8572 Related: kata-containers#8570 Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
fidencio
added a commit
to fidencio/kata-containers
that referenced
this pull request
Dec 29, 2023
We're using a Kernel based on v6.6-rc2, which should already include all the needed patches for SEV / SNP, with the patches for TDX coming atop of that. By doing this, later on, we'll be able to stop building the specific Kernel TDX / Kernel SEV / Kernel SNP targets. It's important to note a few things in this commit here: * The kernel added is based on https://github.com/intel/tdx-linux/tree/tdx-base-v6.6rc2-2023.12.05 * This work serves as base for what the Canonical / Red Hat / SUSE ships on their side for TDX support * As at this point both SEV and SNP work on the guest side should be done, we're safe on only having the TDX patches atop of that version * This work will be updated frequently Apart from those notes, a few small changes were done in the kernel builder script in order to: * Support downloading a tarball from github (instead of the kernel CDN) * Support the "confidential" target for -x (used for TEEs) The TEEs specific builds are being kept as they're for now, as the switch to this new target will be done in a different PR, meaning that the focus right now is just to get these artefacts building in order to facilitate the testing with those before we fully switch to them. Fixes: kata-containers#8571 Related: kata-containers#8570 Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
fidencio
added a commit
to fidencio/kata-containers
that referenced
this pull request
Jan 2, 2024
We're using a Kernel based on v6.6-rc2, which should already include all the needed patches for SEV / SNP, with the patches for TDX coming atop of that. By doing this, later on, we'll be able to stop building the specific Kernel TDX / Kernel SEV / Kernel SNP targets. It's important to note a few things in this commit here: * The kernel added is based on https://github.com/intel/tdx-linux/tree/tdx-base-v6.6rc2-2023.12.05 * This work serves as base for what the Canonical / Red Hat / SUSE ships on their side for TDX support * As at this point both SEV and SNP work on the guest side should be done, we're safe on only having the TDX patches atop of that version * This work will be updated frequently Apart from those notes, a few small changes were done in the kernel builder script in order to: * Support downloading a tarball from github (instead of the kernel CDN) * Support the "confidential" target for -x (used for TEEs) The TEEs specific builds are being kept as they're for now, as the switch to this new target will be done in a different PR, meaning that the focus right now is just to get these artefacts building in order to facilitate the testing with those before we fully switch to them. Fixes: kata-containers#8571 Related: kata-containers#8570 Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@studychao poked me about having this enabled in the CI, but not fully running, so his team can have an easy way to test it in the CI in order to fully enable them.