Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime-rs: add network hotplug for clh #8580

Merged
merged 1 commit into from Dec 6, 2023
Merged

runtime-rs: add network hotplug for clh #8580

merged 1 commit into from Dec 6, 2023

Conversation

amshinde
Copy link
Member

@amshinde amshinde commented Dec 5, 2023

This is required for clh to work with nerdtcl and docker.
This fixes the issues seen with nerdctl while starting a container.
Hoewever, container exit with docker is still broken due to an unrelated
issue.

Fixes: #8579

@katacontainersbot katacontainersbot added the size/medium Average sized task label Dec 5, 2023
@amshinde
Copy link
Member Author

amshinde commented Dec 5, 2023

@fidencio I have tested this PR with nerdctl and docker. This should fix the network issues seen earlier.
However I am seeing another issue with docker, the container is not able to exit while running both an interactive and non-interactive container. From the logs, I see the last log to be about executing the Poststop hooks, but nothing beyond that.
In any case, this looks like a separate issue not related to network that needs further debugging.
I will open a separate issue for that. Meanwhile would appreciate it if you can take a look at this PR and do a quick test on your end as well.

@amshinde amshinde force-pushed the runtime-rs-clh-network-hotplug branch from f75b3c3 to c67ae1c Compare December 5, 2023 23:20
@amshinde
Copy link
Member Author

amshinde commented Dec 5, 2023

/test

@amshinde amshinde force-pushed the runtime-rs-clh-network-hotplug branch from c67ae1c to 6abe3e6 Compare December 5, 2023 23:24
@katacontainersbot katacontainersbot added size/small Small and simple task and removed size/medium Average sized task labels Dec 5, 2023
@amshinde
runtime-rs: add network hotplug for clh
955dec0 
This is required for clh to work with nerdtcl and docker.
This fixes the issues seen with nerdctl while starting a container.
Hoewever, container exit with docker is still broken due to an unrelated
issue.

Fixes: kata-containers#8579

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
@amshinde amshinde force-pushed the runtime-rs-clh-network-hotplug branch from 6abe3e6 to 955dec0 Compare December 5, 2023 23:30
@amshinde
Copy link
Member Author

amshinde commented Dec 5, 2023

/test

@amshinde amshinde mentioned this pull request Dec 5, 2023
Open
cmaf
cmaf approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@cmaf cmaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amshinde LGTM

fidencio
fidencio approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amshinde, I've tested this both with nerdctl and docker, and I could replicate exactly the same results as you did.

lgtm, thanks!

@fidencio fidencio merged commit c14e309 into kata-containers:main Dec 6, 2023
166 of 172 checks passed
@amshinde
Copy link
Member Author

amshinde commented Dec 6, 2023

@amshinde, I've tested this both with nerdctl and docker, and I could replicate exactly the same results as you did.

Thanks for testing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fidencio fidencio fidencio approved these changes

@cmaf cmaf cmaf approved these changes

@GabyCT GabyCT GabyCT approved these changes

@jodh-intel jodh-intel Awaiting requested review from jodh-intel

Assignees
No one assigned
Labels
ok-to-test size/small Small and simple task
Projects
runtime-rs hypervisor integration
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime-rs + clh does not work with nerdctl and docker
5 participants
@amshinde @fidencio @cmaf @GabyCT @katacontainersbot