dragonball: add --all for fmt ci #8599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
liubogithub
approved these changes
Dec 7, 2023
quanweiZhou
approved these changes
Dec 8, 2023
jiangliu
approved these changes
Dec 8, 2023
studychao
force-pushed
the
chao/fix_cargo_fmt
branch
from
111faf5
to
6bcc21b
Compare
|
/test |
studychao
force-pushed
the
chao/fix_cargo_fmt
branch
from
6bcc21b
to
3f9ea68
Compare
|
/test |
Right now, cargo fmt check in Dragonball only test with the default features but not all features. This will cause some code being untested by the fmt tool. This PR adds --all option for the Dragonball CI and also fix some code that forgets to do cargo fmt --all. fixes: kata-containers#8598 Signed-off-by: Chao Wu <chaowu@linux.alibaba.com>
studychao
force-pushed
the
chao/fix_cargo_fmt
branch
from
3f9ea68
to
52f7a40
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, cargo fmt check in Dragonball only test with the default features but not all features. This will cause some code being untested by the fmt tool.
This PR adds --all option for the Dragonball CI and also fix some code that forgets to do cargo fmt --all.
fixes: #8598