dragonball: Use vhost-net device by default #8609
Conversation
There was a problem hiding this comment.
Thx @justxuewei for your work!
But IMO you should split the PR into at least two commits, one for dragonball and one for runtime-rs, rather than having one PR which has only one commit with several changes at different levels.
src/dragonball/src/dbs_virtio_devices/src/vhost/vhost_kern/net.rs
Outdated
Show resolved
Hide resolved
justxuewei
force-pushed
the
runtime-rs-vhost-net
branch
from
64ed632
to
afdcc72
Compare
@Apokleos Thanks for your kindly review. I've split this patch into two commits, one for runtime-rs, another one for dragonball. PTAL. |
justxuewei
force-pushed
the
runtime-rs-vhost-net
branch
from
afdcc72
to
cb73208
Compare
|
/test |
justxuewei
force-pushed
the
runtime-rs-vhost-net
branch
from
cb73208
to
5e9a726
Compare
|
/test |
| fn add_net_device(&mut self, config: &NetworkConfig) -> Result<()> { | ||
| fn add_net_device( | ||
| &mut self, | ||
| hconfig: &HypervisorConfig, |
There was a problem hiding this comment.
IMO, there's no need introduce a hconfig here, you can just get the hypervisor config in add_net_device before you do dragonball_network_device
| } | ||
| /// Generate Dragonball network config according to hypervisor config and | ||
| /// runtime network config. | ||
| pub(crate) fn dragonball_network_config( |
There was a problem hiding this comment.
The function name dragonball_network_config is not clear. I think it'd better to change it to something that is more specific and easier to understand, such as "build_xxx", "setup_xxx", "init_xxx"...
|
/test |
justxuewei
force-pushed
the
runtime-rs-vhost-net
branch
2 times, most recently
from
1804c7b
to
9719dc4
Compare
This patch set vhost-net as default backend of networking. It allows users to set `disable_vhost_net` to `true` to reenable virtio-net backend. Plus, which backend to use is a matter of hypervisor, runtime-rs will no longer need to know that. Fixes: kata-containers#8608 Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
Dragonball sets a default queue config in the case of `None`. The queue_size and num_queues of vhost-net are set to `Some(0)` by default. Therefore, we might get an invalid queue config. This patch fixes this issue. Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
justxuewei
force-pushed
the
runtime-rs-vhost-net
branch
from
9719dc4
to
82fde44
Compare
|
/test |
The default network backend of runtime-rs with Dragonball is vhost-net after kata-containers#8609 merged. The tests might be failed if vhost modules are not loaded. Fixes: kata-containers#8717 Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
The default network backend of runtime-rs with Dragonball is vhost-net after kata-containers#8609 merged. The tests might be failed if vhost modules are not loaded. Fixes: kata-containers#8717 Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
This patch set vhost-net as default backend of networking. It allows users
to set
disable_vhost_nettotrueto reenable virtio-net backend.Plus, which backend to use is a matter of hypervisor, runtime-rs will no
longer need to know that.
Fixes: #8608