runtime-rs: Enhancement of DirectVolume when using a dedicated CSI #8620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apokleos
added
ok-to-test
runtime-rs
no-backport-needed
size/large
Tim-0731-Hzt
approved these changes
Dec 13, 2023
Apokleos
force-pushed
the
enhance-directv-using-csi
branch
from
f3ac69a
to
3c19de3
Compare
Tim-Zhang
approved these changes
Dec 13, 2023
quanweiZhou
approved these changes
Dec 13, 2023
DirectVolume structure in runtime-rs is different from it in kata-runtime, which causes they has no unified handling method for DirectVolumeMountInfo and MountInfo. We should align the two by simply adding the attribute #[serde(rename="x") to each field in DirectVolumeMountInfo Fixes: kata-containers#8619 Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
We use a matching direct-volume path to determine whether an OCI mount is a DirectVolume. However, we should handle the case where no match is found appropriately. This error will be defined as a non-DirectVolume type when judging the OCI mount but not failed. Fixes: kata-containers#8619 Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
Apokleos
force-pushed
the
enhance-directv-using-csi
branch
from
3c19de3
to
aa42f0a
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Enhancement of DirectVolume when using CSI.
We use a matching direct-volume path to determine whether an OCI mount
is a DirectVolume. However, we should handle the case where no match is
found appropriately.
This error will be defined as a non-DirectVolume type when judging the
OCI mount but not failed.
(2) Add attribe serde rename to each field of DirectVolume.
DirectVolume structure in runtime-rs is different from it in kata-runtime,
which causes they has no unified handling method for DirectVolumeMountInfo
and MountInfo.
We should align the two by simply adding the attribute #[serde(rename="x")
to each field in DirectVolumeMountInfo
Fixes: #8619
Signed-off-by: alex.lyn alex.lyn@antgroup.com