New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: k8s: Enable tests for cloud hypervisor runtime-rs without devicemapper #8628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabyCT
force-pushed
the
topic/enablek8stclh
branch
from
December 11, 2023 17:17
07b9726
to
79ba427
Compare
katacontainersbot
added
size/small
Small and simple task
and removed
size/tiny
Smallest and simplest task
labels
Dec 11, 2023
dborquez
approved these changes
Dec 11, 2023
GabyCT
force-pushed
the
topic/enablek8stclh
branch
from
December 11, 2023 20:14
79ba427
to
8d02784
Compare
jodh-intel
reviewed
Dec 15, 2023
@@ -9,6 +9,7 @@ load "${BATS_TEST_DIRNAME}/../../common.bash" | |||
load "${BATS_TEST_DIRNAME}/tests_common.sh" | |||
|
|||
setup() { | |||
[ "${KATA_HYPERVISOR}" == "cloud-hypervisor" ] && skip "test not working" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you raise an issue about these tests not working and then add a link to the issue(s) in these skips
.
GabyCT
force-pushed
the
topic/enablek8stclh
branch
2 times, most recently
from
January 30, 2024 15:51
1fc7fa4
to
4acc9f1
Compare
katacontainersbot
added
size/tiny
Smallest and simplest task
and removed
size/small
Small and simple task
labels
Jan 30, 2024
GabyCT
force-pushed
the
topic/enablek8stclh
branch
2 times, most recently
from
January 30, 2024 20:36
c5179b7
to
81d7142
Compare
katacontainersbot
added
size/small
Small and simple task
and removed
size/tiny
Smallest and simplest task
labels
Jan 30, 2024
GabyCT
force-pushed
the
topic/enablek8stclh
branch
7 times, most recently
from
February 2, 2024 16:42
071e6e4
to
0e390dc
Compare
This PR enable the k8s tests for cloud hypervisor runtime-rs. Fixes kata-containers#8627 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
GabyCT
force-pushed
the
topic/enablek8stclh
branch
from
February 2, 2024 17:59
0e390dc
to
eb5b7d3
Compare
GabyCT
changed the title
tests: k8s: Enable tests for cloud hypervisor runtime-rs
tests: k8s: Enable tests for cloud hypervisor runtime-rs without devicemapper
Feb 6, 2024
GabyCT
force-pushed
the
topic/enablek8stclh
branch
from
February 6, 2024 16:42
c561ff4
to
ff6ab5c
Compare
This PR skips the k8s tests that are not working with cloud hypervisor runtime-rs with its proper issue. Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
GabyCT
force-pushed
the
topic/enablek8stclh
branch
from
February 6, 2024 16:52
ff6ab5c
to
cf049fc
Compare
jodh-intel
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @GabyCT.
lgtm
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enable the k8s tests for cloud hypervisor runtime-rs without devicemapper.
Fixes #8627