Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: k8s: Enable tests for cloud hypervisor runtime-rs without devicemapper #8628

Merged
merged 2 commits into from Feb 6, 2024

Conversation

GabyCT
Copy link
Contributor

@GabyCT GabyCT commented Dec 11, 2023

This PR enable the k8s tests for cloud hypervisor runtime-rs without devicemapper.

Fixes #8627

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Dec 11, 2023
@katacontainersbot katacontainersbot added size/small Small and simple task and removed size/tiny Smallest and simplest task labels Dec 11, 2023
@GabyCT GabyCT added the do-not-merge PR has problems or depends on another label Dec 11, 2023
@@ -9,6 +9,7 @@ load "${BATS_TEST_DIRNAME}/../../common.bash"
load "${BATS_TEST_DIRNAME}/tests_common.sh"

setup() {
[ "${KATA_HYPERVISOR}" == "cloud-hypervisor" ] && skip "test not working"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you raise an issue about these tests not working and then add a link to the issue(s) in these skips.

@GabyCT GabyCT force-pushed the topic/enablek8stclh branch 2 times, most recently from 1fc7fa4 to 4acc9f1 Compare January 30, 2024 15:51
@katacontainersbot katacontainersbot added size/tiny Smallest and simplest task and removed size/small Small and simple task labels Jan 30, 2024
@GabyCT GabyCT force-pushed the topic/enablek8stclh branch 2 times, most recently from c5179b7 to 81d7142 Compare January 30, 2024 20:36
@katacontainersbot katacontainersbot added size/small Small and simple task and removed size/tiny Smallest and simplest task labels Jan 30, 2024
@GabyCT GabyCT force-pushed the topic/enablek8stclh branch 7 times, most recently from 071e6e4 to 0e390dc Compare February 2, 2024 16:42
This PR enable the k8s tests for cloud hypervisor runtime-rs.

Fixes kata-containers#8627

Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
@GabyCT GabyCT changed the title tests: k8s: Enable tests for cloud hypervisor runtime-rs tests: k8s: Enable tests for cloud hypervisor runtime-rs without devicemapper Feb 6, 2024
@GabyCT GabyCT removed the do-not-merge PR has problems or depends on another label Feb 6, 2024
This PR skips the k8s tests that are not working with cloud hypervisor
runtime-rs with its proper issue.

Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @GabyCT.

lgtm

@GabyCT
Copy link
Contributor Author

GabyCT commented Feb 6, 2024

/test

@GabyCT GabyCT merged commit 6337f30 into kata-containers:main Feb 6, 2024
286 of 445 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/small Small and simple task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: k8s: enable tests for cloud hypervisor runtime-rs
4 participants