Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dragonball: introduce vhost-user-blk device #8632

Merged
merged 2 commits into from Dec 27, 2023
Merged

dragonball: introduce vhost-user-blk device #8632

merged 2 commits into from Dec 27, 2023

Conversation

adamqqqplay
Copy link
Contributor

@adamqqqplay adamqqqplay commented Dec 12, 2023 •
edited

This patch introduces a feature of supporting vhost-user-blk device.

This device needs to be defined before the VM instance is started,
which can be done through the dbs-cli tool with --virblks option:
--virblks '{
        "drive_id": "8623",
        "device_type": "Spdk",
        "path_on_host": "spdk:///var/tmp/vhost.sock",
        "is_root_device": false,
        "is_read_only": false,
        "is_direct": false,
        "no_drop": false,
        "num_queues": 1,
        "queue_size": 256
}'

Fixes: #8631

@katacontainersbot katacontainersbot added the size/huge Largest and most complex task (probably needs breaking into small pieces) label Dec 12, 2023
Apokleos
Apokleos reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@Apokleos Apokleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @adamqqqplay for your great work. Some comments

src/dragonball/src/dbs_virtio_devices/Cargo.toml Show resolved Hide resolved
src/dragonball/src/dbs_virtio_devices/src/vhost/vhost_user/block.rs Show resolved Hide resolved
src/dragonball/src/dbs_virtio_devices/src/vhost/vhost_user/block.rs Show resolved Hide resolved
src/dragonball/src/dbs_virtio_devices/src/vhost/vhost_user/block.rs Show resolved Hide resolved
src/dragonball/src/dbs_virtio_devices/src/vhost/vhost_user/test_utils.rs Show resolved Hide resolved
src/dragonball/src/device_manager/blk_dev_mgr.rs Show resolved Hide resolved
justxuewei
justxuewei reviewed Dec 22, 2023
View reviewed changes
Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adamqqqplay! Look good to me overall, but a few comments here.

src/dragonball/src/dbs_virtio_devices/src/vhost/vhost_user/block.rs Outdated Show resolved Hide resolved
src/dragonball/src/dbs_virtio_devices/src/vhost/vhost_user/block.rs Outdated Show resolved Hide resolved
src/dragonball/src/dbs_virtio_devices/src/vhost/vhost_user/block.rs Outdated Show resolved Hide resolved
src/dragonball/src/dbs_virtio_devices/src/vhost/vhost_user/block.rs Outdated Show resolved Hide resolved
src/dragonball/src/dbs_virtio_devices/src/vhost/vhost_user/block.rs Show resolved Hide resolved
src/dragonball/src/dbs_virtio_devices/src/vhost/vhost_user/block.rs Outdated Show resolved Hide resolved
src/dragonball/src/dbs_virtio_devices/src/vhost/vhost_user/block.rs Outdated Show resolved Hide resolved
src/dragonball/src/dbs_virtio_devices/src/vhost/vhost_user/block.rs Outdated Show resolved Hide resolved
src/dragonball/src/dbs_virtio_devices/src/vhost/vhost_user/block.rs Outdated Show resolved Hide resolved
src/dragonball/src/device_manager/blk_dev_mgr.rs Outdated Show resolved Hide resolved
@adamqqqplay adamqqqplay mentioned this pull request Dec 22, 2023
Open
Apokleos
Apokleos reviewed Dec 22, 2023
View reviewed changes
Copy link
Contributor

@Apokleos Apokleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

src/dragonball/src/dbs_virtio_devices/Cargo.toml Show resolved Hide resolved
src/dragonball/Cargo.toml Outdated Show resolved Hide resolved
@adamqqqplay adamqqqplay force-pushed the support-vhost-user-blk branch 4 times, most recently from 3e56fd2 to 2e7d7c3 Compare December 25, 2023 06:37
justxuewei
justxuewei approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@justxuewei
Copy link
Member

/test

@justxuewei
Copy link
Member

/test

@justxuewei
Copy link
Member

/test-arm

Apokleos
Apokleos approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@Apokleos Apokleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @adamqqqplay great work! LGTM!

@justxuewei
Copy link
Member

/test

@adamqqqplay
dragonball: support vhost-user-blk
ef8dc3b 
This patch introduces a feature of supporting vhost-user-blk device.

This device needs to be defined before the VM instance is started,
which can be done through the dbs-cli tool with --virblks option:
--virblks '{
	"drive_id": "8623",
	"device_type": "Spdk",
	"path_on_host": "spdk:///var/tmp/vhost.sock",
	"is_root_device": false,
	"is_read_only": false,
	"is_direct": false,
	"no_drop": false,
	"num_queues": 1,
	"queue_size": 256
}'

Fixes: kata-containers#8631

Signed-off-by: Eric Ren <renzhen@linux.alibaba.com>
Signed-off-by: fupan <fupan.lfp@antgroup.com>
Signed-off-by: Liu Jiang <gerry@linux.alibaba.com>
Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
@adamqqqplay
dragonball: support vhost-user-blk in device manager
81ab174 
This patch introduces a feature of supporting vhost-user-blk device.

Fixes: kata-containers#8631

Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
@justxuewei
Copy link
Member

/test

@justxuewei justxuewei merged commit 43a627c into kata-containers:main Dec 27, 2023
166 of 176 checks passed
@adamqqqplay adamqqqplay deleted the support-vhost-user-blk branch December 27, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justxuewei justxuewei justxuewei approved these changes

@Apokleos Apokleos Apokleos approved these changes

Assignees
No one assigned
Labels
ok-to-test size/huge Largest and most complex task (probably needs breaking into small pieces)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dragonball: support vhost-user-blk device
4 participants
@adamqqqplay @justxuewei @Apokleos @katacontainersbot