New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA: Put all the preliminary steps into pre-action for s390x #8649
GHA: Put all the preliminary steps into pre-action for s390x #8649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @BbolroC!
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BbolroC - this LGTM. For reference, is the pre_action script, or a summary of the steps that it does available anywhere? I'm thinking that it would be useful to anyone else adding a self-hosted runner to set what things are done in it. I'm not sure the best place to share it though except maybe a list of the steps it does in this commit message?
They are located in an internal repo for building a self-hosted runner for s390x (ansible-playbook). You can see what is going on in those steps from log for the workflow steps like:
If necessary, I could place |
Great point - I didn't think of that. I think that is good enough - thanks! |
This is to introduce a pre-action to all the workflows for building artifacts. The action could take care of tasks such as cleaning up files and reinstalling packages, which prevents a workflow from getting affected by the environment. This also includes the removal of the step `Adjust a permission for repo`, because it could be incorporated into the action. Fixes: kata-containers#8648 Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
f6bd4a5
to
05e278d
Compare
/test |
This is to introduce a pre-action to all the workflows for building artifacts. The action could take care of tasks such as cleaning up files and reinstalling packages, which prevents a workflow from getting affected by the environment.
This also includes the removal of the step
Adjust a permission for repo
, because it could be incorporated into the action.Fixes: #8648
Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com