metrics: Improve latency network cleanup #8659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dborquez
requested changes
Dec 13, 2023
| kubectl delete -f latency-client.yaml | ||
| } | ||
|
|
||
| trap latency_cleanup EXIT |
There was a problem hiding this comment.
If the script ends before the server and clients pods are created, call to latency_cleanup could report error.
I can think of two options, :
- You can make that the lines that deletes the pods return always true
- or move the
trapline just after the creation of the server and client pods.
There was a problem hiding this comment.
thanks @dborquez for the feedback changes applied
GabyCT
force-pushed
the
topic/improvecleanuplatency
branch
2 times, most recently
from
ba89fbc
to
6350df9
Compare
This PR improves the latency network cleanup by removing the pods even if the test fails. Fixes kata-containers#8658 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
GabyCT
force-pushed
the
topic/improvecleanuplatency
branch
from
6350df9
to
8151117
Compare
dborquez
approved these changes
Dec 13, 2023
chavafg
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the latency network cleanup by removing the pods even if the test fails.
Fixes #8658