dragonball: introduce pci msi/msix interrupt #8662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katacontainersbot
added
the
size/huge
studychao
force-pushed
the
pci/4-upstream
branch
from
79f7ac8
to
4c03bde
Compare
jiangliu
approved these changes
Dec 15, 2023
justxuewei
reviewed
Dec 18, 2023
There was a problem hiding this comment.
Thanks @studychao! I don't have enough time to go through your code, leaving msix.rs unreviewed. I'll review the rest part later. Here is some comments.
| @@ -18,3 +18,7 @@ log = "0.4.14" | |||
| downcast-rs = "1.2.0" | |||
| byteorder = "1.4.3" | |||
| thiserror = "1" | |||
| vm-memory = "0.9.0" | |||
There was a problem hiding this comment.
Please upgrade vm-memory to 0.10.0 to keep consistent with others.
There was a problem hiding this comment.
Btw, I found dbs_acpi's vm-memory is still 0.9.0. Do we upgrade that as well?
There was a problem hiding this comment.
vm-memory in pci part is upgraded.
dbs_acpi part will be taken care in later PR.
| impl MsiCap { | ||
| /// Create a new PCI MSI capability structure. | ||
| pub fn new(next: u8, mut msg_ctl: u16) -> Self { | ||
| let cap_id_next = (next as u16) << 8 | PciCapabilityID::MessageSignalledInterrupts as u16; |
There was a problem hiding this comment.
nit: PciCapabilityID -> PciCapabilityId
| // Safe to unwrap() because we have just enabled interrupt successfully. | ||
| let group = intr_manager.get_group().unwrap(); | ||
| for idx in 0..self.num_enabled_vectors() { | ||
| if (self.mask_bits >> idx) & 0x1 != 0 { |
There was a problem hiding this comment.
Maybe use VECTOR_MASK_BIT = 0x1 as aforementioned.
| ) -> std::io::Result<()> { | ||
| if self.enabled() { | ||
| for idx in 0..self.num_enabled_vectors() { | ||
| match ((self.mask_bits >> idx) & 0x1, (mask >> idx) & 0x1) { |
| let group = intr_manager.get_group().unwrap(); | ||
| group.unmask(idx as InterruptIndex)?; | ||
| } | ||
| _ => {} |
studychao
force-pushed
the
pci/4-upstream
branch
from
4c03bde
to
2f8d858
Compare
|
@justxuewei hi, I have updated the PR according to your suggestion. Please take a look. |
studychao
force-pushed
the
pci/4-upstream
branch
2 times, most recently
from
37b9384
to
0afd77a
Compare
|
/test |
studychao
force-pushed
the
pci/4-upstream
branch
from
0afd77a
to
0aed0ca
Compare
|
/test |
|
/test-arm |
studychao
force-pushed
the
pci/4-upstream
branch
from
0aed0ca
to
819ec45
Compare
|
/test |
|
/test-s390x |
introduce msi/msix mod to maintain information for PCI Message Signalled Interrupt Extended Capability. It will be initialized when parsing pci configuration space and used when getting interrupt capabilities. fixes: kata-containers#8661 Signed-off-by: Gerry Liu <gerry@linux.alibaba.com> Signed-off-by: Zizheng Bian <zizheng.bian@linux.alibaba.com> Signed-off-by: Shifang Feng <fengshifang@linux.alibaba.com> Signed-off-by: Yang Su <yang.su@linux.alibaba.com> Signed-off-by: Zha Bin <zhabin@linux.alibaba.com> Signed-off-by: Xin Lin <jingshan@linux.alibaba.com> Signed-off-by: Chao Wu <chaowu@linux.alibaba.com>
studychao
force-pushed
the
pci/4-upstream
branch
from
819ec45
to
8cf3bce
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce msi/msix mod to maintain information for PCI Message Signalled Interrupt Extended Capability. It will be initialized when parsing pci configuration space and used when getting interrupt capabilities.
fixes: #8661
Signed-off-by: Gerry Liu gerry@linux.alibaba.com
Signed-off-by: Zizheng Bian zizheng.bian@linux.alibaba.com
Signed-off-by: Shifang Feng fengshifang@linux.alibaba.com
Signed-off-by: Yang Su yang.su@linux.alibaba.com
Signed-off-by: Zha Bin zhabin@linux.alibaba.com
Signed-off-by: Xin Lin jingshan@linux.alibaba.com
Signed-off-by: Chao Wu chaowu@linux.alibaba.com
v2