ci: Use static checks from kata repo for lib functions #8682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the two functions in lib.sh to use the static checks script from the kata containers repo instead of tests. Remove cloning the repo from these functions since we don't need it anymore. Leave these two functions because the document checking one may be used locally and the static checks one is called from the virtcontainers Makefile. Fixes kata-containers#8681 Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>
We now use the static checks script from the main kata containers repo and not the tests repo; update documentation to reflect this. Fixes kata-containers#8681 Signed-off-by: Chelsea Mafrica <chelsea.e.mafrica@intel.com>
cmaf
added
ok-to-test
no-backport-needed
and removed
size/small
gkurz
approved these changes
Dec 18, 2023
|
/test |
GabyCT
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the two functions in lib.sh to use the static checks script from
the kata containers repo instead of tests. Remove cloning the repo from
these functions since we don't need it anymore. Leave these two
functions because the document checking one may be used locally and the
static checks one is called from the virtcontainers Makefile.
Fixes #8681
Signed-off-by: Chelsea Mafrica chelsea.e.mafrica@intel.com