agent: hold lock while setting new policy #8735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amshinde
approved these changes
Dec 30, 2023
danmihai1
force-pushed
the
danmihai1/set-policy
branch
from
c696734
to
3db3e66
Compare
Don't release the lock between is_allowed and set_policy calls, because the policy might change in between these calls. Also, move more policy code into policy.rs. Fixes: kata-containers#8734 Signed-off-by: Dan Mihai <dmihai@microsoft.com>
danmihai1
force-pushed
the
danmihai1/set-policy
branch
from
3db3e66
to
7d5336a
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't release the lock between is_allowed and set_policy calls, because the policy might change in between these calls.
Also, move more policy code into policy.rs.
Fixes: #8734