ci: test dragonball stability and cri-containerd #8737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apokleos
force-pushed
the
test-ci-dgb-cri-containerd
branch
from
3d64e7a
to
ed23a9f
Compare
Apokleos
force-pushed
the
test-ci-dgb-cri-containerd
branch
7 times, most recently
from
b2bfe81
to
9fc8235
Compare
Apokleos
requested review from
fidencio,
Tim-0731-Hzt,
studychao,
Tim-Zhang and
lifupan
Apokleos
force-pushed
the
test-ci-dgb-cri-containerd
branch
2 times, most recently
from
4605ecf
to
a363b39
Compare
|
/test |
Apokleos
force-pushed
the
test-ci-dgb-cri-containerd
branch
2 times, most recently
from
bc9f4a1
to
9432428
Compare
|
/test |
fidencio
reviewed
Jan 9, 2024
Comment on lines
631
to
636
| # if [ "$KATA_HYPERVISOR" != "dragonball" ]; then | ||
| # TestContainerMemoryUpdate 1 | ||
| # TestContainerMemoryUpdate 0 | ||
| # fi | ||
|
|
||
| # TestContainerMemoryUpdate 0 |
There was a problem hiding this comment.
Hi @fidencio Honestly, I'm not sure if this is the right way to do it, or if there's a better way to solve the CI error issue. The current situation is that runtime-rs/qemu does not have this feature implemented.
Apokleos
force-pushed
the
test-ci-dgb-cri-containerd
branch
6 times, most recently
from
34f2402
to
4744c09
Compare
studychao
reviewed
Jan 11, 2024
|
|
||
| if [ $test_virtio_mem -eq 1 ]; then | ||
| if [[ "$ARCH" != "x86_64" ]]; then | ||
| return | ||
| fi | ||
| info "Test container memory update with virtio-mem" | ||
|
|
||
| sudo sed -i -e 's/^#enable_virtio_mem.*$/enable_virtio_mem = true/g' "${kata_config}" |
There was a problem hiding this comment.
why can't we use kata_config here?
Apokleos
force-pushed
the
test-ci-dgb-cri-containerd
branch
3 times, most recently
from
64b9a5b
to
8f6b812
Compare
It needs to remove the skip setting, and make it work for dragonball. Fixes: kata-containers#8746 Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
Containerd runtime options with wrong setting cause it failed.
Correct it as below:
...
[plugins.cri.containerd.runtimes.${runtime}.options]
ConfigPath= "${KATA_CONFIG_PATH}"
...
Fixes: kata-containers#8746
Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
Apokleos
force-pushed
the
test-ci-dgb-cri-containerd
branch
from
8f6b812
to
25e32af
Compare
katacontainersbot
added
size/medium
lifupan
approved these changes
Jan 11, 2024
Fixes: kata-containers#8746 Signed-off-by: alex.lyn <alex.lyn@antgroup.com>
Apokleos
force-pushed
the
test-ci-dgb-cri-containerd
branch
from
25e32af
to
b97efc3
Compare
Tim-0731-Hzt
approved these changes
Jan 12, 2024
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: make CI work for dragonball to test stability and cri-containerd
It needs to remove the skip setting, and make it work for dragonball.
bugfix when CI running cri-containerd
Fixes #8746