Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-rs|agent|protocols|agent-ctl: Bump ttrpc and containerd-shim-protos versions #8757

Merged

Conversation

justxuewei
Copy link
Member

@justxuewei justxuewei commented Jan 2, 2024

The affected crates in this repo are runtime-rs, agent, protocols and agent-ctl.

The crates that are upgraded are:

  • ttrpc from 0.7.1 to 0.8.
  • containerd-shim-protos from 0.3.0 to 0.6.0.

Fixes: #8756

@katacontainersbot katacontainersbot added the size/huge Largest and most complex task (probably needs breaking into small pieces) label Jan 2, 2024
@justxuewei
Copy link
Member Author

/test

@justxuewei justxuewei changed the title runtime-rs|agent|protocols: Bump ttrpc and containerd-shim-protos version runtime-rs|agent|protocols: Bump ttrpc and containerd-shim-protos versions Jan 2, 2024
@justxuewei justxuewei force-pushed the upgrade-containerd-shim-protos branch from 59a0378 to ca6cce1 Compare January 2, 2024 03:28
justxuewei added a commit to justxuewei/kata-containers that referenced this pull request Jan 2, 2024
- `ttrpc` from `0.7.1` to `0.8`.

Fixes: kata-containers#8757

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
Copy link
Member

@studychao studychao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you describe the reason why you need to bump the version ( what problem do you need to solve) in the commit message or issue?

@justxuewei justxuewei changed the title runtime-rs|agent|protocols: Bump ttrpc and containerd-shim-protos versions runtime-rs|agent|protocols|agent-ctl: Bump ttrpc and containerd-shim-protos versions Jan 2, 2024
@justxuewei
Copy link
Member Author

Hey @studychao. I've updated the reason on the issue. Please take a look. Thanks!

Copy link
Member

@studychao studychao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@Tim-Zhang Tim-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @justxuewei

Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @justxuewei, thanks for this.

Except the Static checks / build-checks-depending-on-kvm (runtime-rs) (pull_request) Failing after 6m that is required, this LGTM.

@justxuewei
Copy link
Member Author

/test

- `ttrpc` from `0.7.1` to `0.8`.

Fixes: kata-containers#8756

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
- `ttrpc` from `0.7.1` to `0.8`.

Fixes: kata-containers#8756

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
- `ttrpc` from `0.7.1` to `0.8`.
- `containerd-shim-protos` from `0.3.0` to `0.6.0`.

Fixes: kata-containers#8756

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
- `ttrpc` from `0.7.1` to `0.8`.

Fixes: kata-containers#8757

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
@justxuewei justxuewei force-pushed the upgrade-containerd-shim-protos branch from ca6cce1 to f97f16a Compare January 4, 2024 07:58
@justxuewei
Copy link
Member Author

/test

@justxuewei justxuewei merged commit db948f6 into kata-containers:main Jan 4, 2024
167 of 176 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/huge Largest and most complex task (probably needs breaking into small pieces)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime-rs|agent|protocols|agent-ctl: Bump ttrpc and containerd-shim-protos versions
5 participants