Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update docs for new StratoVirt VMM introduction #8759

Merged

Conversation

fadecoder
Copy link
Contributor

@fadecoder fadecoder commented Jan 2, 2024

As the StratoVirt VMM has been added, we can update the docs and make some intoduction to StratoVirt, thus users can know more about the hypervisor choices.

Fixes: #8645

@fadecoder fadecoder requested a review from a team as a code owner January 2, 2024 07:28
@katacontainersbot katacontainersbot added the size/medium Average sized task label Jan 2, 2024
@WenyuanLau
Copy link
Contributor

Thanks! @fadecoder

Can anyone in Documentation Team take a look?
cc @kata-containers/documentation

@fadecoder fadecoder force-pushed the update_docs_for_stratoVirt_VMM branch from 62b973a to 6b6d557 Compare January 2, 2024 07:47
@fadecoder fadecoder force-pushed the update_docs_for_stratoVirt_VMM branch 2 times, most recently from 8446fe6 to 07b323c Compare January 2, 2024 11:46
@@ -254,7 +270,7 @@ applying labels to the nodes.
This DaemonSet installs the necessary Kata binaries, configuration files, and virtual machine artifacts on
the node. Once installed, the DaemonSet adds a node label `katacontainers.io/kata-runtime=true` and reconfigures
either CRI-O or containerd to register three `runtimeClasses`: `kata-clh` (for Cloud Hypervisor isolation), `kata-qemu` (for QEMU isolation),
and `kata-fc` (for Firecracker isolation). As a final step the DaemonSet restarts either CRI-O or containerd. Upon deletion,
, `kata-fc` (for Firecracker isolation) and `kata-stratovirt` (for StratoVirt isolation). As a final step the DaemonSet restarts either CRI-O or containerd. Upon deletion,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits: previous line already ends in a comma, Add a new line break to keep doc lines to the recommended 120 chars

Suggested change
, `kata-fc` (for Firecracker isolation) and `kata-stratovirt` (for StratoVirt isolation). As a final step the DaemonSet restarts either CRI-O or containerd. Upon deletion,
`kata-fc` (for Firecracker isolation) and `kata-stratovirt` (for StratoVirt isolation).
As a final step the DaemonSet restarts either CRI-O or containerd. Upon deletion,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks,updated.

@fadecoder fadecoder force-pushed the update_docs_for_stratoVirt_VMM branch from 07b323c to 6ef0658 Compare January 3, 2024 06:25
@stevenhorsman
Copy link
Member

/test

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs looks okay to me, running the tests now to check there aren't any issues, but I can't envisage any

@WenyuanLau
Copy link
Contributor

Docs looks okay to me, running the tests now to check there aren't any issues, but I can't envisage any

Thanks! @stevenhorsman

@WenyuanLau WenyuanLau self-requested a review January 3, 2024 10:29

[StratoVirt](https://gitee.com/openeuler/stratovirt) is an enterprise-level open source VMM oriented to cloud data centers, implements a unified architecture to support Standard-VMs, containers and serverless (Micro-VM). StratoVirt has some competitive advantages, such as lightweight and low resource overhead, fast boot, hardware acceleration, and language-level security with Rust.

Currently, StratoVirt in Kata supports Micro-VM machine type, mainly focus on FaaS cases, supporting device hotplug (virtio block), file-system sharing through virtio fs and so on.Kata Containers with StratoVirt now use virtio-mmio bus as driver, and doesn't support CPU/memory resize nor VFIO, thus doesn't support updating container resources after booted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a space before "Kata": ...and so on.Kata Containers with StratoVirt... -> ...virtio fs and so on. Kata Containers with StratoVirt...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks,updated

As the StratoVirt VMM has been added, we can update the docs
and make some intoduction to StratoVirt, thus users can know more
about the hypervisor choices.

Fixes: kata-containers#8645

Signed-off-by: Zhigang Wang <wangzhigang17@huawei.com>
Signed-off-by: Liu Wenyuan <liuwenyuan9@huawei.com>
@fadecoder fadecoder force-pushed the update_docs_for_stratoVirt_VMM branch from 6ef0658 to 44b5b88 Compare January 4, 2024 06:46
Copy link
Contributor

@Apokleos Apokleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @fadecoder LGTM!

@Apokleos
Copy link
Contributor

Apokleos commented Jan 4, 2024

/test

@GabyCT GabyCT merged commit f056ffe into kata-containers:main Jan 4, 2024
162 of 175 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/medium Average sized task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add StratoVirt to hypervisors page
6 participants