virtiofs: Disable DAX #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtiofs DAX support is not stable today, there are a few corner cases to make it default. Fixes: kata-containers#862 Fixes: kata-containers#875 Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
amshinde
approved these changes
Oct 8, 2020
likebreath
approved these changes
Oct 8, 2020
egernst
reviewed
Oct 8, 2020
| @@ -173,7 +173,8 @@ DEFSHAREDFS := virtio-9p | |||
| DEFSHAREDFS_QEMU_VIRTIOFS := virtio-fs | |||
| DEFVIRTIOFSDAEMON := $(VIRTIOFSDBINDIR)/virtiofsd | |||
| # Default DAX mapping cache size in MiB | |||
| DEFVIRTIOFSCACHESIZE := 1024 | |||
| #if value is 0, DAX is not enabled | |||
| DEFVIRTIOFSCACHESIZE := 0 | |||
There was a problem hiding this comment.
Makes sense to me.
Though, for 2.0, should we change the default to virtio-fs w/ out DAX for the 'qemu' configuration? I would think 2.0 is the time to switch from 9p -> virtiofs, unless there are stability concerns.
If we do the above, then I'd consider being able to enable DAX still for the 'qemu-virtiofs' configuration of Kata, but disabled for 'qemu' and 'clh' configurations...
There was a problem hiding this comment.
+1. We should open another issue to discuss it though. The PR meant to forward port a 1.x commit.
bergwolf
approved these changes
Oct 9, 2020
|
/test-ubuntu |
|
/test-clh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtiofs DAX support is not stable today, there are
a few corner cases to make it default.
Fixes: #862
Fixes: #875
Signed-off-by: Jose Carlos Venegas Munoz jose.carlos.venegas.munoz@intel.com