Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backport check hub #8763

Merged
merged 2 commits into from Jan 11, 2024

Conversation

stevenhorsman
Copy link
Member

Add gh-util.sh script

Fixes: #8125

@stevenhorsman stevenhorsman added force-skip-ci Stop the CI running for a PR (remember: if you break it, you fix it!) no-backport-needed labels Jan 3, 2024
@stevenhorsman
Copy link
Member Author

/test

@katacontainersbot katacontainersbot added the size/large Task of significant size label Jan 3, 2024
@stevenhorsman stevenhorsman removed the force-skip-ci Stop the CI running for a PR (remember: if you break it, you fix it!) label Jan 3, 2024
@GabyCT
Copy link
Contributor

GabyCT commented Jan 4, 2024

seems like a fix needs to be done

[static-checks.sh:1153] INFO: Checking script file 'ci/gh-util.sh'
[static-checks.sh:935] ERROR: Expected 'EOF' here anchor, in ci/gh-util.sh found: EOT

- The hub tool is now deprecated, so introduce a new alternative to `hub-util.sh`
https://github.com/kata-containers/.github/blob/main/scripts/hub-util.sh
that works with it.
Initially I've only started with the couple of commands that we use regularly, but we can extend it in future.
- Expects jq to be installed and `gh` to be installed an setup (see [1])
- Now we don't have lots of repos, I've moved it into `kata-containers` rather than `.github`,
so it is more visible.

Fixes: kata-containers#8125

[1] https://docs.github.com/en/github-cli/github-cli/quickstart#prerequisites

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
- hub is deprecated, so use the new gh-utils.sh script that wraps the github cli instead

Fixes: kata-containers#8125
Signed-off-by: stevenhorsman <steven@uk.ibm.com>
@stevenhorsman
Copy link
Member Author

seems like a fix needs to be done

Thanks for flagging that up. Sorry I missed it, but should be okay now...

@stevenhorsman
Copy link
Member Author

/test

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @stevenhorsman!

@GabyCT GabyCT merged commit 2ffb161 into kata-containers:main Jan 11, 2024
176 of 180 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/large Task of significant size
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gha: Add backport label is failing
4 participants