New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix backport check hub #8763
Merged
GabyCT
merged 2 commits into
kata-containers:main
from
stevenhorsman:fix-backport-check-hub
Jan 11, 2024
Merged
Fix backport check hub #8763
GabyCT
merged 2 commits into
kata-containers:main
from
stevenhorsman:fix-backport-check-hub
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenhorsman
added
force-skip-ci
Stop the CI running for a PR (remember: if you break it, you fix it!)
no-backport-needed
labels
Jan 3, 2024
/test |
stevenhorsman
removed
the
force-skip-ci
Stop the CI running for a PR (remember: if you break it, you fix it!)
label
Jan 3, 2024
seems like a fix needs to be done
|
- The hub tool is now deprecated, so introduce a new alternative to `hub-util.sh` https://github.com/kata-containers/.github/blob/main/scripts/hub-util.sh that works with it. Initially I've only started with the couple of commands that we use regularly, but we can extend it in future. - Expects jq to be installed and `gh` to be installed an setup (see [1]) - Now we don't have lots of repos, I've moved it into `kata-containers` rather than `.github`, so it is more visible. Fixes: kata-containers#8125 [1] https://docs.github.com/en/github-cli/github-cli/quickstart#prerequisites Signed-off-by: stevenhorsman <steven@uk.ibm.com>
- hub is deprecated, so use the new gh-utils.sh script that wraps the github cli instead Fixes: kata-containers#8125 Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
force-pushed
the
fix-backport-check-hub
branch
from
January 4, 2024 16:48
b76d35c
to
6bac332
Compare
Thanks for flagging that up. Sorry I missed it, but should be okay now... |
/test |
fidencio
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @stevenhorsman!
GabyCT
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gh-util.sh script
hub-util.sh
https://github.com/kata-containers/.github/blob/main/scripts/hub-util.sh
that works with it.
Initially I've only started with the couple of commands that we use regularly, but we can extend it in future.
gh
to be installed an setup (see https://docs.github.com/en/github-cli/github-cli/quickstart#prerequisites workflows: Update backport-label to use gh-utils.sh)kata-containers
rather than.github
,so it is more visible.
Fixes: #8125