agent: Fix an issue reporting OOM events by mistake #8773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justxuewei
force-pushed
the
dbs-k8s-fragile
branch
from
15de588
to
7e1aeab
Compare
justxuewei
force-pushed
the
dbs-k8s-fragile
branch
from
7e1aeab
to
e292ece
Compare
Apokleos
reviewed
Jan 4, 2024
| @@ -165,22 +166,17 @@ async fn register_memory_event( | |||
|
|
|||
| tokio::spawn(async move { | |||
| loop { | |||
| let sender = sender.clone(); | |||
There was a problem hiding this comment.
Cuz clone() is unnecessary here.
|
/test |
Tim-Zhang
approved these changes
Jan 5, 2024
justxuewei
force-pushed
the
dbs-k8s-fragile
branch
2 times, most recently
from
ff86888
to
fb3cf6b
Compare
The agent registers an event fd in `memory.oom_control`. An OOM event is forwarded to containerd when the event is emitted, regardless of the content in that file. I observed content indicating that events should not be forwarded, as shown below. When `oom_kill` is set to 0, it means no OOM has occurred. Therefore, it is important to check the content to avoid mistakenly forwarding OOM events. ``` oom_kill_disable 0 under_oom 0 oom_kill 0 ``` Fixes: kata-containers#8715 Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
justxuewei
force-pushed
the
dbs-k8s-fragile
branch
from
fb3cf6b
to
0e9d73f
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The agent registers an event fd in
memory.oom_control. An OOM event isforwarded to containerd when the event is emitted, regardless of the
content in that file.
I observed content indicating that events should not be forwarded, as shown
below. When
oom_killis set to 0, it means no OOM has occurred. Therefore,it is important to check the content to avoid mistakenly forwarding OOM
events.
Fixes: #8715