runtime-rs: Forward events to containerd via ttrpc #8780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katacontainersbot
added
the
size/huge
justxuewei
force-pushed
the
containerd-events
branch
5 times, most recently
from
9769fba
to
5b5e397
Compare
quanweiZhou
reviewed
Jan 10, 2024
justxuewei
force-pushed
the
containerd-events
branch
from
5b5e397
to
4688708
Compare
quanweiZhou
reviewed
Jan 11, 2024
justxuewei
force-pushed
the
containerd-events
branch
2 times, most recently
from
26ad7d1
to
3807d6a
Compare
quanweiZhou
approved these changes
Jan 11, 2024
It is a little bit heavy for the runtime-rs to forwards events via containerd CLI, contrast to the ttrpc way. Plus, for runtimes that haven't this mechanism, e.g. CRI-O, we can't get those events anywhere. This patch introduces two types of forwarders: - `ContainerdForwarder`: Acquire ttrpc address from environment variables and forward events via ttrpc connection. - `LogForwarder`: Write event info into logs. Fixes: kata-containers#7881 Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
justxuewei
force-pushed
the
containerd-events
branch
from
3807d6a
to
6fd49f7
Compare
Tim-0731-Hzt
approved these changes
Jan 11, 2024
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a little bit heavy for the runtime-rs to forward events via
containerd CLI, contrast to the ttrpc way. Plus, for runtimes that haven't
this mechanism, e.g. CRI-O, we can't get those events anywhere.
This patch introduces two types of forwarders:
ContainerdForwarder: Acquire ttrpc address from environment variablesand forward events via ttrpc connection.
LogForwarder: Write event info into logs.Fixes: #7881