runtime-rs: ch: Unbreak CH driver #8803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fidencio
reviewed
Jan 11, 2024
| } | ||
|
|
||
| pub(crate) fn resize_memory(&self, _new_mem_mb: u32) -> Result<(u32, MemoryConfig)> { | ||
| todo!() | ||
| // No resize currently - see https://github.com/kata-containers/kata-containers/issues/8801 |
There was a problem hiding this comment.
@jodh-intel, I think it's worth adding a message here saying that the resize is not currently implemented.
There was a problem hiding this comment.
Done. I've also converted the 1st commit to return an error as that doesn't break the default use-case but does provide a GH issue URL too.
jodh-intel
force-pushed
the
issues-8784-runtime-rs-ch-rm-todo-to-unbreak
branch
from
2e01ca4
to
5d93a69
Compare
Remove the `todo!()` macro which would cause a runtime crash and replace with a implementation that returns an error as a stop-gap until kata-containers#8800 is implemented. Fixes: kata-containers#8785. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Replace the `todo!()` calls with a minimal NOP implementation to return the CH driver to working order since the `todo!()`'s forcibly crash the driver at runtime. Full implementations for these APIs will be added on issues kata-containers#8800, kata-containers#8801, and kata-containers#8802. Fixes: kata-containers#8784. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
issues-8784-runtime-rs-ch-rm-todo-to-unbreak
branch
from
5d93a69
to
29e0de4
Compare
jodh-intel
added
safe-to-test
|
/test |
amshinde
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, PR #6876 broke running runtime-rs with Cloud Hypervisor so add minimal implementations of the new APIs to allow CH to be used with runtime-rs.
Full implementations will be added later on issues #8800, #8801, and #8802.