New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: remove SharedVersions field dead code #8812
runtime: remove SharedVersions field dead code #8812
Conversation
acdfb40
to
3b84c4a
Compare
Hi @gkurz! |
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @kalil-pelissier !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @kalil-pelissier!
@kalil-pelissier Please rebase on main to fix the build-checks not starting issue. |
SharedVersion fiel add a versiontable property that isn't supported by upstream QEMU. This is dead code since virtcontainers isn't setting SharedVersions to true. Fixes: kata-containers#7720 Signed-off-by: Kvlil <kalil.pelissier@gmail.com>
3b84c4a
to
a4b208a
Compare
/test |
/retest-arm-unit |
SharedVersion fiel add a versiontable property that isn't supported by upstream QEMU. This is dead code since virtcontainers isn't setting SharedVersions to true.
Fixes: #7720