Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: Remove iperf3 server protocol #8830

Merged
merged 1 commit into from Jan 15, 2024

Conversation

GabyCT
Copy link
Contributor

@GabyCT GabyCT commented Jan 15, 2024

This PR removes the iperf3 server protocol as this server definition is also used for the UDP iperf3 benchmarks to avoid duplication of the same yaml files.

Fixes #8829

This PR removes the iperf3 server protocol as this server definition is
also used for the UDP iperf3 benchmarks to avoid duplication of the
same yaml files.

Fixes kata-containers#8829

Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
@GabyCT
Copy link
Contributor Author

GabyCT commented Jan 15, 2024

/test

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only change needed?

You mentioned about avoid duplication, is there already a file duplicated or you're avoiding to add a new one?

@GabyCT
Copy link
Contributor Author

GabyCT commented Jan 15, 2024

Is this the only change needed?

You mentioned about avoid duplication, is there already a file duplicated or you're avoiding to add a new one?

@fidencio yes this is the only change that is needed, and I am avoid to add a new one just for UDP (avoid duplication)

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @GabyCT!

@GabyCT GabyCT merged commit 37a4049 into kata-containers:main Jan 15, 2024
182 of 264 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics: remove iperf3 server protocol
4 participants