New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gha: get ready to install genpolicy #8857
Conversation
/test |
Hi @danmihai1 ! Allow me to check if I understood. Although kata-deploy installs genpolicy tool on the cluster, for testing sake it is needed the binary on the runner machine. So it gets the same tarball used on create the kata-deploy payload image then extracts on the runner machine. One side question: would make sense for the user to run |
Indeed, a customer would run genpolicy even before they created a cluster - and you described all the reasons why correctly. |
@danmihai1, right now I see why we can have it as you proposed. However, in the future, I'd like us to create a second tarball that can be downloaded without getting the whole kata-containers bundle. Would it be possible to create an issue for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left one comment in the code, which will make our lives slightly easier in the future.
Done: #8864 |
The changes to install and test genpolicy must come later, after CI picks up these gha changes. Fixes: kata-containers#8856 Signed-off-by: Dan Mihai <dmihai@microsoft.com>
c59bab6
to
ea9c659
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With @fidencio 's suggestions it looks better now. Thanks @danmihai1 !
The changes to install and test genpolicy must come later, after CI picks up these gha changes.
Fixes: #8856