Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: Cache the agent for non-x86_64 arches #8926

Merged

Conversation

fidencio
Copy link
Member

Those are not yet being cached for no reason, and they better be as it'll allow us to save a considerable amount of time building the rootfs.

Fixes: #8917

NOTE: The agent-opa is not in the scope for this, and I will leave it for the maintainers of each specific architecture to do so, and to also add the dependency to their specific rootfs as done for this one in a previous commit.

Those are not yet being cached for no reason, and they better be as
it'll allow us to save a considerable amount of time building the
rootfs.

Fixes: kata-containers#8917

Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Jan 26, 2024
Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch ! Thanks @fidencio !

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@BbolroC
Copy link
Member

BbolroC commented Jan 26, 2024

/test

@fidencio
Copy link
Member Author

/retest-arm-unit

@BbolroC
Copy link
Member

BbolroC commented Jan 26, 2024

Why don't we merge this? Static checks / build-checks (agent, sudo -E PATH="$PATH" make test, ppc64le) has not been picked up quite a while.

@BbolroC BbolroC merged commit ee072e8 into kata-containers:main Jan 26, 2024
290 of 305 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache: Cache the agent for non-x86_64 architectures
6 participants