New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime-rs: report error on missing or empty fields in configuration #8929
runtime-rs: report error on missing or empty fields in configuration #8929
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/test |
Please rebase atop of main to get the CI passed. |
Please correct your email. |
49e6953
to
f504d7b
Compare
rebased and corrected my email |
/test |
Removed the setting of default values for runtime fields. Added explicit checks for missing or empty fields, reporting errors with clear messages. Fixes: kata-containers#8838 Signed-off-by: yaoyinnan <35447132+yaoyinnan@users.noreply.github.com>
f504d7b
to
864389c
Compare
/test |
Removed the setting of default values for runtime fields. Added explicit checks for missing or empty fields, reporting errors with clear messages.
Fixes: #8838