Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-rs: report error on missing or empty fields in configuration #8929

Merged
merged 1 commit into from Feb 1, 2024

Conversation

yaoyinnan
Copy link
Member

Removed the setting of default values for runtime fields. Added explicit checks for missing or empty fields, reporting errors with clear messages.

Fixes: #8838

Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

Copy link
Contributor

@Apokleos Apokleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justxuewei
Copy link
Member

/test

@justxuewei
Copy link
Member

Please rebase atop of main to get the CI passed.

@justxuewei
Copy link
Member

Please correct your email.

@yaoyinnan
Copy link
Member Author

Please rebase atop of main to get the CI passed.

rebased and corrected my email

@yaoyinnan
Copy link
Member Author

/test

Removed the setting of default values for runtime fields. Added explicit checks for missing or empty fields, reporting errors with clear messages.

Fixes: kata-containers#8838

Signed-off-by: yaoyinnan <35447132+yaoyinnan@users.noreply.github.com>
@yaoyinnan
Copy link
Member Author

/test

@Apokleos Apokleos merged commit 1b8f3ce into kata-containers:main Feb 1, 2024
281 of 295 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/small Small and simple task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime-rs: error message is inaccurate and misleading when Kata uses a misconfigured config
4 participants