runtime-rs: Log qemu's stderr in shim log #8938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a flaw pointed out in review of PR kata-containers#8185. Creation of the directory semantically fits better into VM preparation than VM launch. Signed-off-by: Pavel Mores <pmores@redhat.com>
gkurz
reviewed
Jan 29, 2024
|
Just a nit, can we prefix PRs that target runtime-rs with |
|
I'm sorry, I thought the prefix only applies to commit messages and didn't realise that it applies to PR titles as well. Next time around (I don't think I can fix it for this one)! |
gkurz
changed the title
Yes you can. There's an |
We'll want to capture qemu's stderr in parallel with normal runtime-rs execution. Tokio's primitives make this much easier than std's. This also makes child process management more consistent across runtime-rs (i.e. virtiofsd child process is already launched and managed using tokio). Some changes were necessary due to tokio functions being slightly different from their std counterparts. Child::kill() is now async and Child::id() now returns an Option. Signed-off-by: Pavel Mores <pmores@redhat.com>
Qemu stderr monitoring runs in its own asynchronous green thread. For that, `stderr` is taken out of the Child representing the qemu child process to avoid partial move and make it possible for the main thread still to call functions on QemuInner::qemu_process (e.g. kill(), id()). Fixes kata-containers#8937 Signed-off-by: Pavel Mores <pmores@redhat.com>
pmores
force-pushed
the
log-qemus-stderr-in-shim-log
branch
from
40be3ad
to
d53edbd
Compare
gkurz
approved these changes
Jan 30, 2024
|
/test |
GabyCT
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a ready access to qemu's stderr is immensely helpful in debugging qemu's launch failures. Qemu's stderr output is now included in regular shim's log (look for lines prepended with "qemu stderr: ").
An unrelated small fix promised in review of PR #8185 is also included in this PR's initial commit.