runtime: add SingleContainer when obtaining OCI Spec #8974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
Apokleos
reviewed
Jan 31, 2024
| // represents the pause container. In Docker, this is the container. | ||
| // On Linux, we derive the group path from this container. | ||
| // Get the container associated with the PodSandbox annotation. | ||
| // In Kubernetes, this represents the pause container. In Docker, this is the container. |
There was a problem hiding this comment.
It seems that "In Docker" is not appropriate today. Should we make it more generic?
There was a problem hiding this comment.
Yes, I changed it to "CRI-compatible runtime like Containerd"
When creating a cgroup, add a SingleContainer when obtaining the OCI Spec to apply to ctr, podman, etc. Fixes: kata-containers#5240 Signed-off-by: yaoyinnan <35447132+yaoyinnan@users.noreply.github.com>
yaoyinnan
force-pushed
the
5240/fix/cgroup-parallel
branch
from
701d4c0
to
9aa1ed8
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a cgroup, add a SingleContainer when obtaining the OCI Spec to apply to ctr, podman, etc.
Fixes: #5240