gha: delete azure RG only if it exists #9007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wainersm
added
no-backport-needed
area/ci
sprt
approved these changes
Feb 2, 2024
tests/gha-run-k8s-common.sh
Outdated
| local rg | ||
| rg="$(_print_rg_name ${test_type})" | ||
|
|
||
| if [ "$(az group exists -n "${rg}")" == "true" ]; then |
There was a problem hiding this comment.
Suggested change
| if [ "$(az group exists -n "${rg}")" == "true" ]; then | |
| if [ "$(az group exists -g "${rg}")" == "true" ]; then |
If we want to be consistent with other commands.
tests/gha-run-k8s-common.sh
Outdated
Comment on lines
111
to
113
| az group delete \ | ||
| -g "${rg}" \ | ||
| --yes |
There was a problem hiding this comment.
Suggested change
| az group delete \ | |
| -g "${rg}" \ | |
| --yes | |
| az group delete -g "${rg}" --yes |
Tiny bit more readable.
delete_cluster() has tried to delete the az resources group regardless if it exists. In some cases the result of that operation is ignored, i.e., fail to resource group not found, but the log messages get a little dirty. Let's delete the RG only if it exists then. Fixes kata-containers#8989 Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
wainersm
force-pushed
the
aks_delete_rg
branch
from
8c92832
to
a04b215
Compare
katacontainersbot
added
size/tiny
|
Just updated to address @sprt 's suggestions. |
danmihai1
approved these changes
Feb 2, 2024
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete_cluster() has tried to delete the az resources group regardless if it exists. In some cases the result of that operation is ignored, i.e., fail to resource group not found, but the log messages get a little dirty. Let's delete the RG only if it exists then.
Fixes #8989
Signed-off-by: Wainer dos Santos Moschetta wainersm@redhat.com
Split of #8990