tests/runk: fix the "run ps command" flaky test #9009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wainersm
added
area/ci
wainersm
changed the title
ManaSugi
reviewed
Feb 13, 2024
| [ $status -eq 1 ] | ||
| # Check kill --all should not fail | ||
| sudo ctr t kill --signal SIGKILL --all "${CONTAINER_ID}" | ||
| } |
danmihai1
approved these changes
Feb 14, 2024
|
|
||
| setup_file() { | ||
| export RUNK_BIN_PATH="/usr/local/bin/runk" | ||
| export TEST_IMAGE="docker.io/library/busybox:latest" |
There was a problem hiding this comment.
Is quay.io/prometheus/busybox preferrable, to work around image repository limits?
There was a problem hiding this comment.
hi @danmihai1 ! you are right, fixed!
GabyCT
reviewed
Feb 22, 2024
| [ "${STATUS}" == "RUNNING" ] | ||
| } | ||
|
|
||
| teardown() { |
There was a problem hiding this comment.
There was a problem hiding this comment.
hi @GabyCT , you mean use check_processes to ensure that shimv2 process really got killed?
Migrated runk tests from pure shell script to bats to be consistent with other test suites. The install_dependencies() will install the bats tool locally. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Likely copied from the tracing workflow by mistake. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
The "run ps command" test has failed once in a while because it doesn't wait the sh command to start within the container, consequently `ps` won't report the amount of lines expected. Fixes kata-containers#8975 Signed-off-by: Manabu Sugimoto <Manabu.Sugimoto@sony.com> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
It's recommended to avoid images from docker.io to avoid errors related with hitting the pull limits that happens mostly on bare-metal machines. So this replaced the docker.io's busybox with quay.io/prometheus/busybox. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
|
Updates:
|
ManaSugi
approved these changes
Feb 27, 2024
|
lgtm, thanks @wainersm ! |
|
/test |
1 similar comment
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "run ps command" test of the runk suite has failed intermittently. So here I'm fixing that but before I converted it to bats entirely; it should help on future maintenance of the test suite besides of improving the reporting text.
Fixes #8975