Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kata-monitor: fix agentUrl from containerd shim #9012

Merged
merged 1 commit into from Feb 5, 2024

Conversation

deagon
Copy link
Contributor

@deagon deagon commented Feb 4, 2024

It should be "/agent-url" here.

Fix: #9013

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Feb 4, 2024
@deagon
Copy link
Contributor Author

deagon commented Feb 4, 2024

@liubin @fengwang666 Take a review pls.

@justxuewei
Copy link
Member

Hi @deagon. Thanks for your contribution. The format of commit message is incorrect. Please refer to this doc. Your PR will not be merged until you fix that.

Fix the missing leading slash.

Fixes: kata-containers#9013
Signed-off-by: Guoqiang Ding <dgq8211@gmail.com>
@deagon
Copy link
Contributor Author

deagon commented Feb 4, 2024

Hi @deagon. Thanks for your contribution. The format of commit message is incorrect. Please refer to this doc. Your PR will not be merged until you fix that.

@justxuewei Sorry for my misoperation.

Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@justxuewei
Copy link
Member

/test

Copy link
Contributor

@Apokleos Apokleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @deagon LGTM!

@Apokleos Apokleos merged commit 51a82be into kata-containers:main Feb 5, 2024
283 of 295 checks passed
@deagon deagon deleted the fix/monitor-agent-url branch February 5, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kata-monitor: 404 NotFound for "/agent-url" endpoint
4 participants