Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: display accurate error msg to avoid misleading users. #9015

Merged
merged 1 commit into from Feb 5, 2024

Conversation

Apokleos
Copy link
Contributor

@Apokleos Apokleos commented Feb 4, 2024

runtime: display accurate error msg to avoid misleading users.

The original handling method does not reach user expectations.
When the ClientSocketAddress method stats the corresponding
path of runtime-rs and has not found it yet, we should return
an error message here that includes the reason for the failure
(which should be an error display indicating that both runtime-go
and runtime-rs were not found). Instead of simply displaying the
corresponding path of runtime-rs as the final error message to
users.
It is also necessary to return the error promptly to the caller
for further error handling.

Fixes: #8999

Signed-off-by: Alex Lyn alex.lyn@antgroup.com

@katacontainersbot katacontainersbot added the size/small Small and simple task label Feb 4, 2024
The original handling method does not reach user expectations.
When the ClientSocketAddress method stats the corresponding
path of runtime-rs and has not found it yet, we should return
an error message here that includes the reason for the failure
(which should be an error display indicating that both runtime-go
and runtime-rs were not found). Instead of simply displaying the
corresponding path of runtime-rs as the final error message to
users.
It is also necessary to return the error promptly to the caller
for further error handling.

Fixes: kata-containers#8999

Signed-off-by: Alex Lyn <alex.lyn@antgroup.com>
@Apokleos Apokleos changed the title runtime: return accurate error msg to avoid misleading users. runtime: display accurate error msg to avoid misleading users. Feb 4, 2024
Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@Apokleos
Copy link
Contributor Author

Apokleos commented Feb 5, 2024

/test

@Apokleos Apokleos self-assigned this Feb 5, 2024
@Apokleos Apokleos merged commit cf74166 into kata-containers:main Feb 5, 2024
293 of 459 checks passed
@Apokleos Apokleos deleted the bugfix-exec-uds branch February 5, 2024 05:50
WeiZhang555

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/small Small and simple task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants