Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: Run static-checks on self-hosted runners conditionally #9020

Merged

Conversation

BbolroC
Copy link
Member

@BbolroC BbolroC commented Feb 5, 2024

Due to the restrictions on instance provisioning for self-hosted runners, performing static checks (36 jobs at the time of writing) on them each time a PR is updated could significantly burden them, consequently slowing down the entire CI system. To address this, the decision is to trigger these checks only when an 'ok-to-test' label is added. Meanwhile, the checks for x86_64, which are supported by GitHub-hosted runners, will remain unchanged.

Fixes: #8998

Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com

@katacontainersbot katacontainersbot added the size/large Task of significant size label Feb 5, 2024
@BbolroC BbolroC requested a review from wainersm February 5, 2024 10:45
@BbolroC BbolroC force-pushed the ok-to-test-static-checks-but-x86 branch from 9b5a409 to 7767700 Compare February 5, 2024 10:48
@BbolroC BbolroC force-pushed the ok-to-test-static-checks-but-x86 branch 4 times, most recently from 7b31e78 to e04aa1b Compare February 5, 2024 14:08
Due to the restrictions on instance provisioning for self-hosted runners, performing
static checks (36 jobs at the time of writing) on them each time a PR is updated could
significantly burden them, consequently slowing down the entire CI system. To address
this, the decision is to trigger these checks only when an 'ok-to-test' label is added.
Meanwhile, the checks for x86_64, which are supported by GitHub-hosted runners, will
remain unchanged.

Fixes: kata-containers#8998

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@BbolroC BbolroC force-pushed the ok-to-test-static-checks-but-x86 branch from e04aa1b to 40b2b2a Compare February 5, 2024 14:24
@BbolroC
Copy link
Member Author

BbolroC commented Feb 5, 2024

All checks are passed as planned.

@BbolroC
Copy link
Member Author

BbolroC commented Feb 6, 2024

/test

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @BbolroC & @wainersm!

Copy link
Contributor

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @BbolroC !

@wainersm
Copy link
Contributor

wainersm commented Feb 6, 2024

Hi @stevenhorsman ! We will need to re-do the list of required jobs as the actual build-checks changed of name.

@stevenhorsman
Copy link
Member

Hi @stevenhorsman ! We will need to re-do the list of required jobs as the actual build-checks changed of name.

I can disable them now and then in ~10 days we'll re-enable them to give people grace period to re-base?

@stevenhorsman
Copy link
Member

Hi @stevenhorsman ! We will need to re-do the list of required jobs as the actual build-checks changed of name.

I can disable them now and then in ~10 days we'll re-enable them to give people grace period to re-base?

Hmm, given there are so many, I might raise this on the AC meeting first.

@wainersm
Copy link
Contributor

wainersm commented Feb 6, 2024

Hi @stevenhorsman ! We will need to re-do the list of required jobs as the actual build-checks changed of name.

I can disable them now and then in ~10 days we'll re-enable them to give people grace period to re-base?

Hmm, given there are so many, I might raise this on the AC meeting first.

Yeah, it would be better to discuss on AC. I completely overlooked the actual PRs, they will need all to be rebased :(

@BbolroC
Copy link
Member Author

BbolroC commented Feb 6, 2024

Yeah, again, this is something @gkurz also wanted to discuss on the AC meeting. 😭

@wainersm wainersm added do-not-merge PR has problems or depends on another and removed do-not-merge PR has problems or depends on another labels Feb 6, 2024
@fidencio fidencio merged commit 058f068 into kata-containers:main Feb 6, 2024
529 of 551 checks passed
@BbolroC BbolroC deleted the ok-to-test-static-checks-but-x86 branch February 6, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/large Task of significant size
Projects
None yet
Development

Successfully merging this pull request may close these issues.

static-checks: CI slowdown from unconditional job triggers on self-hosted runner
5 participants