rootfs: confidential: Install coco-guest-components #9022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fidencio
added
ok-to-test
merge-to-main
fidencio
force-pushed
the
topic/add-guest-components-to-the-confidential-image-and-initrd
branch
from
53e4dea
to
a21c27b
Compare
tools/packaging/kata-deploy/local-build/kata-deploy-binaries.sh
Outdated
Show resolved
Hide resolved
fidencio
force-pushed
the
topic/add-guest-components-to-the-confidential-image-and-initrd
branch
from
a21c27b
to
d617d1b
Compare
stevenhorsman
approved these changes
Feb 5, 2024
tools/packaging/kata-deploy/local-build/kata-deploy-binaries.sh
Outdated
Show resolved
Hide resolved
As DESTDIR was not being passed, we've been installing the final binaries in a container path that was not exposed to the host, leading to creating an empty tarball with the guest components. Now, theoretically, guest-components should respect a PREFIX passed, but that's not the case and we're manually adding "/usr/local/bin" to the passed DESTDIR. Here's the result of the tarball: ```bash ⋊> kata-containers ≡ tar tf build/kata-static-coco-guest-components.tar.xz ./ ./usr/ ./usr/local/ ./usr/local/bin/ ./usr/local/bin/confidential-data-hub ./usr/local/bin/attestation-agent ./usr/local/bin/api-server-rest ``` Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
fidencio
force-pushed
the
topic/add-guest-components-to-the-confidential-image-and-initrd
branch
2 times, most recently
from
3bb188b
to
562afc7
Compare
We need to pass this to the container where the rootfs is built, so it can actually be unpacked inside the rootfs. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
This will make our lives easier to figure out whether the components are being installed or not. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
Let's install the coco-guest-components into the confidential rootfs image and initrd. Fixes: kata-containers#9021 Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
fidencio
force-pushed
the
topic/add-guest-components-to-the-confidential-image-and-initrd
branch
from
562afc7
to
27e7974
Compare
katacontainersbot
added
size/medium
|
/test |
danmihai1
approved these changes
Feb 5, 2024
ryansavino
reviewed
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's install the coco-guest-components into the confidential rootfs image and initrd.
Fixes: #9021