Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools.kata-webhook: Fix lib path #9023

Merged
merged 1 commit into from Feb 15, 2024
Merged

tools.kata-webhook: Fix lib path #9023

merged 1 commit into from Feb 15, 2024

Conversation

ldoktor
Copy link
Contributor

@ldoktor ldoktor commented Feb 5, 2024

When moving the webhook we skipped the common.bash as (close-enough) version is already in /tests but we forgot to update the source path, fixing it here.

@ldoktor
tools.kata-webhook: Fix lib path
3b0049b 
When moving the webhook we skipped the common.bash as (close-enough)
version is already in `/tests` but we forgot to update the source path,
fixing it here.

Fixes: kata-containers#8653

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
@wainersm wainersm added area/ci Issues affecting the continuous integration no-backport-needed labels Feb 5, 2024
@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Feb 5, 2024
wainersm
wainersm approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ldoktor !

fidencio
fidencio approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @ldoktor!

stevenhorsman
stevenhorsman approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Lukas!

@wainersm
Copy link
Contributor

/test

@ldoktor
Copy link
Contributor Author

ldoktor commented Feb 15, 2024

Hello folks, can I ask what is blocking this PR? I can see 3 approvals and the failing tests do not look related to me (actually I see them as waste of resources given this code does not touches anything related, do you think it'd make sense to investigate some time and skip them in such cases? I'd be willing to work on that)

@wainersm
Copy link
Contributor

Hello folks, can I ask what is blocking this PR? I can see 3 approvals and the failing tests do not look related to me (actually I see them as waste of resources given this code does not touches anything related, do you think it'd make sense to investigate some time and skip them in such cases? I'd be willing to work on that)

Sorry for the delay to merge this, @ldoktor . I had to run some flaky jobs many times until all required were passing.

@wainersm wainersm merged commit db744aa into kata-containers:main Feb 15, 2024
303 of 312 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fidencio fidencio fidencio approved these changes

@wainersm wainersm wainersm approved these changes

@stevenhorsman stevenhorsman stevenhorsman approved these changes

Assignees
No one assigned
Labels
area/ci Issues affecting the continuous integration ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldoktor @wainersm @fidencio @stevenhorsman @katacontainersbot