Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cri-containerd: fix loop in TestContainerMemoryUpdate() #9025

Merged
merged 1 commit into from Feb 6, 2024

Conversation

wainersm
Copy link
Contributor

@wainersm wainersm commented Feb 5, 2024

The loop that generate test cases for virtio-mem enabled/disabled doesn't return the integers '1' and '0' as expected. Instead it returns the strings '{1,' and '0}'.

Fixes #9024
Signed-off-by: Wainer dos Santos Moschetta wainersm@redhat.com

The loop that generate test cases for virtio-mem enabled/disabled
doesn't return the integers '1' and '0' as expected. Instead it returns
the strings '{1,' and '0}'.

Fixes kata-containers#9024
Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
@wainersm wainersm added no-backport-needed area/testing Issues related to testing labels Feb 5, 2024
@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Feb 5, 2024
Copy link
Contributor

@Apokleos Apokleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @wainersm you're right!
LGTM!

Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@justxuewei
Copy link
Member

/test

@justxuewei justxuewei merged commit 67d9847 into kata-containers:main Feb 6, 2024
299 of 310 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues related to testing ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/cri-containerd: error integer expression expected
4 participants