runtime: fix creation of SEV confidential container on SNP enabled host. #9037
Conversation
niteeshkd
force-pushed
the
nd_SevSnpGuest
branch
2 times, most recently
from
79526f8
to
32bc08f
Compare
There was a problem hiding this comment.
@niteeshkd, would you mind to add a commiit message explaining why this is needed?
If this is a regression, mind to mention when we regressed?
This kind of information is crucial for maintainers to navigate through the history of the projects (and bugs, and fixes).
|
Answering some of my own questions here, it seems that the regression was introduced by de39fb7 (which, if had been merged with a reasonable commit message would have made our lives easier at this point --)). Let's also loop in @zvonkok to the loop to make sure it doesn't break his GPU related work, and if it does break, figure out the best way to solve. |
niteeshkd
force-pushed
the
nd_SevSnpGuest
branch
from
32bc08f
to
ca2304f
Compare
@fidencio updated the commit message. |
This is needed to fix the bug which is not allowing to create SEV container on SNP enabled host anymore. This is a regression that was introduced as part of the following commit: kata-containers@de39fb7 Fixes: kata-containers#9036 Signed-off-by: Niteesh Dubey <niteesh@us.ibm.com>
niteeshkd
force-pushed
the
nd_SevSnpGuest
branch
from
ca2304f
to
3e38367
Compare
|
Created #9040 to add a test in future. |
|
All required checks are passing on this one. @stevenhorsman @danmihai1 @fidencio We good to merge this? |
|
/test |
Fixes the issue #9036 .