Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime-rs: fix assert error in make check #9043

Merged
merged 1 commit into from Feb 8, 2024
Merged

runtime-rs: fix assert error in make check #9043

merged 1 commit into from Feb 8, 2024

Conversation

ChengyuZhu6
Copy link
Member

@ChengyuZhu6 ChengyuZhu6 commented Feb 7, 2024 •
edited

Fix assert error:

error: used `assert_eq!` with a literal bool
   --> crates/hypervisor/src/ch/inner.rs:218:9
    |
218 |         assert_eq!(state.jailed, false);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
    = note: `-D clippy::bool-assert-comparison` implied by `-D warnings`

Fixes: #9042

@ChengyuZhu6
runtime-rs: fix assert error in test in make check
34c47e0 
Fix assert error:
error: used `assert_eq!` with a literal bool
   --> crates/hypervisor/src/ch/inner.rs:218:9
    |
218 |         assert_eq!(state.jailed, false);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
    = note: `-D clippy::bool-assert-comparison` implied by `-D warnings`

Fixes: kata-containers#9042

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Feb 7, 2024
@ChengyuZhu6 ChengyuZhu6 changed the title runtime-rs: fix assert error in test in make check runtime-rs: fix assert error in make check Feb 7, 2024
fidencio
fidencio approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @ChengyuZhu6!

Out of curiosity, what's the toolchain version you used to get this error?

@ChengyuZhu6
Copy link
Member Author

lgtm, thanks @ChengyuZhu6!

Out of curiosity, what's the toolchain version you used to get this error?

This error occurred in the CI: https://github.com/kata-containers/kata-containers/actions/runs/7813648790/job/21313249271?pr=9031

@danmihai1
Copy link
Contributor

/test

@danmihai1 danmihai1 merged commit 535db6b into kata-containers:main Feb 8, 2024
349 of 573 checks passed
@ChengyuZhu6 ChengyuZhu6 deleted the assert branch February 8, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fidencio fidencio fidencio approved these changes

@danmihai1 danmihai1 danmihai1 approved these changes

@amshinde amshinde Awaiting requested review from amshinde

@jodh-intel jodh-intel Awaiting requested review from jodh-intel

@studychao studychao Awaiting requested review from studychao

Assignees
No one assigned
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runtime-rs: build error in make check
4 participants
@ChengyuZhu6 @danmihai1 @fidencio @katacontainersbot