Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nydus: Bump nydus snapshotter version to v0.13.7 #9045

Merged
merged 1 commit into from Feb 7, 2024

Conversation

ChengyuZhu6
Copy link
Member

@ChengyuZhu6 ChengyuZhu6 commented Feb 7, 2024

Bump nydus snapshotter version to v0.13.7.

The new release name of nydus snapshotter is nydus-snapshotter-v0.13.7-linux-amd64.tar.gz, which differs from the version used by kata (nydus-snapshotter-v0.12.0-x86_64.tgz). Therefore, we need to update the script to obtain the correct nydus snapshotter name.

Fixes: #9044

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Feb 7, 2024
@ChengyuZhu6 ChengyuZhu6 added no-backport-needed ok-to-test and removed size/tiny Smallest and simplest task labels Feb 7, 2024
@ChengyuZhu6 ChengyuZhu6 force-pushed the nydus-version branch 2 times, most recently from 2b8e4a4 to 313cd37 Compare February 7, 2024 12:26
@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Feb 7, 2024
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @ChengyuZhu6!

@fidencio
Copy link
Member

fidencio commented Feb 7, 2024

/test

tests/common.bash Outdated Show resolved Hide resolved
Copy link
Contributor

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With @stevenhorsman 's suggestion

Bump nydus snapshotter version to v0.13.7.
The new release name of nydus snapshotter is `nydus-snapshotter-v0.13.7-linux-amd64.tar.gz`,
which differs from the version used by kata (`nydus-snapshotter-v0.12.0-x86_64.tgz`).
Therefore, we need to update the script to obtain the correct nydus snapshotter name.

Fixes: kata-containers#9044

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
@ChengyuZhu6
Copy link
Member Author

With @stevenhorsman 's suggestion

Thanks @wainersm. I have fixed it.

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ChengyuZhu6

@stevenhorsman
Copy link
Member

/test

Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@stevenhorsman stevenhorsman merged commit 934d8dc into kata-containers:main Feb 7, 2024
283 of 293 checks passed
@ChengyuZhu6 ChengyuZhu6 deleted the nydus-version branch February 20, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nydus: Bump nydus snapshotter version to v0.13.7
7 participants