tests:k8s: make add_kernel_initrd_anotations function generic #9061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR replaces the add_kernel_initrd_annotations_to_yaml function more generic so later can be used for other components. Fixes kata-containers#9054 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
GabyCT
changed the title
|
@fidencio changes applied |
|
/test |
fidencio
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
lgtm, @GabyCT, thanks!
And looking at the logs of the tests:
# io.katacontainers.config.hypervisor.initrd: /opt/kata/share/kata-containers/kata-containers-initrd-mariner.img
# io.katacontainers.config.hypervisor.kernel: /usr/share/cloud-hypervisor/vmlinux.bin
We can see that the annotations are still being passed correctly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the add_kernel_initrd_annotations_to_yaml function more generic so later can be used for other components.
Fixes #9054