Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: release notes: Don't show shortlist by default, and add survey link #9076

Merged

Conversation

jodh-intel
Copy link
Contributor

Add a link in the release notes to the Kata Container survey, to
advertise it, and hopefully encourage users to take the survey.

Add a "twistie" / arrow () that the user can click on to see the full
list of commits if they want to.

This way, the release notes become easier to read and we can display
information below the shortlog which would (probably) normally not be
seen due to the huge long list of commits.

Fixes: #9075.
Fixes: #9074.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

@katacontainersbot katacontainersbot added the size/small Small and simple task label Feb 12, 2024
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @jodh-intel!

Copy link

@ildikov ildikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James for adding the Kata User Survey link to the release notes. I added a small suggestion in line to the text in that segment.

Thanks,
Ildikó

tools/packaging/release/release-notes.sh Outdated Show resolved Hide resolved
@jodh-intel jodh-intel force-pushed the add-survey-link-to-release-notes branch from f416f1c to 97ae6e7 Compare February 14, 2024 15:54
@jodh-intel jodh-intel added safe-to-test Add to PR after manually reviewing to allow certain extra checks to run ok-to-test labels Feb 15, 2024
@jodh-intel
Copy link
Contributor Author

/test

Add a "twistie" / arrow (`▶`) that the user can click on to see the full
list of commits _if they want to_.

This way, the release notes become easier to read and we can display
information below the shortlog which would (probably) normally not be
seen due to the huge long list of commits.

Fixes: kata-containers#9075.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Add a link in the release notes to the Kata Container survey, to
advertise it, and hopefully encourage users to take the survey.

Fixes: kata-containers#9074.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel jodh-intel force-pushed the add-survey-link-to-release-notes branch from 97ae6e7 to 8c72abe Compare February 23, 2024 09:58
@jodh-intel
Copy link
Contributor Author

/test

@jodh-intel jodh-intel merged commit 0ea30f4 into kata-containers:main Feb 26, 2024
285 of 295 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test safe-to-test Add to PR after manually reviewing to allow certain extra checks to run size/small Small and simple task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packaging: Add twistie in release notes for shortlog packaging: Add survey link to release notes
6 participants