New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packaging: Add the kata manager script #9091
packaging: Add the kata manager script #9091
Conversation
@jodh-intel, what's included as part of the release is actually in https://github.com/kata-containers/kata-containers/blob/main/.github/workflows/build-kata-static-tarball-amd64.yaml#L29 Now, the question whether we want to ship as part of the tarball, or as its own file uploaded to github as part of the release. Let's sync about this Tomorrow, @jodh-intel. |
87fbdf8
to
4840ee6
Compare
Branch updated to resolve merge conflict. |
@fidencio - Thanks, I've also updated the YAML config file now 😄 For a bit more detail on why this PR is useful... Once #9059 lands, you'll be able to switch hypervisor config by running a "one line" command using $ bash -c "$(curl -fsSL https://raw.githubusercontent.com/kata-containers/kata-containers/main/utils/kata-manager.sh) -S clh ... or, when this PR lands and gets into a release, you could do the same thing by running simply:
Which is a lot easier to remember and type 😄 |
So, I tried to run make kata-manager-tarball
make: *** No rule to make target 'kata-manager-tarball'. Stop. After adding the patch below it works as expected: diff --git a/tools/packaging/kata-deploy/local-build/Makefile b/tools/packaging/kata-deploy/local-build/Makefile
index d85382fd1..a6986191f 100644
--- a/tools/packaging/kata-deploy/local-build/Makefile
+++ b/tools/packaging/kata-deploy/local-build/Makefile
@@ -111,6 +111,9 @@ pause-image-tarball:
kata-ctl-tarball:
${MAKE} $@-build
+kata-manager-tarball:
+ ${MAKE} $@-build
+
kernel-dragonball-experimental-tarball:
${MAKE} $@-build |
Remove some unnecessary whitespace from a couple of `kata-deploy` files. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com> whitespace Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Create a variable for the default binary permissions. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Add `kata-manager.sh` to the release packages. Fixes: kata-containers#9066. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
4840ee6
to
8c51e02
Compare
Thanks, @fidencio! Branch updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @jodh-intel.
There are a bunch of whitespace changes that are not related to this PR, but let it be. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @jodh-intel
/test |
Add
kata-manager.sh
to the release packages.Fixes: #9066.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com