Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootfs: Fix PAUSE_IMAGE_TARBALL addition to the rootfs #9180

Conversation

fidencio
Copy link
Member

We were never passing the arguments to add the PAUSE_IMAGE to the rootfs, leading to it never being present in the confidential image / initrd.

Fixes: #9032 -- part II

@fidencio
Copy link
Member Author

/test

Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @fidencio !

@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Feb 28, 2024
@fidencio fidencio force-pushed the topic/actually-add-the-pause-image-into-the-rootfs branch from 66e4bd4 to 30cbcea Compare February 28, 2024 21:41
We were never passing the arguments to add the PAUSE_IMAGE to the
rootfs, leading to it never being present in the confidential image /
initrd.

Fixes: kata-containers#9032 -- part II

Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
@fidencio fidencio force-pushed the topic/actually-add-the-pause-image-into-the-rootfs branch from 30cbcea to 0022474 Compare February 28, 2024 21:42
Copy link
Member

@ChengyuZhu6 ChengyuZhu6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @fidencio ! Thanks for the fix !

@fidencio
Copy link
Member Author

/test

@gkurz gkurz merged commit 58bc026 into kata-containers:main Feb 29, 2024
262 of 296 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CC: Integrate pause image into rootfs
5 participants