gha: Add cloud-hypervisor (runtime-rs) support to cri-containerd tests #9182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the Cloud Hypervisor driver, integrated with the runtime-rs, as part of the cri-containerd tests. Fixes kata-containers#9181 Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
This PR skips the cri-containerd in gha-run script for cloud hypervisor runtime-rs. Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
This PR implements general fixes to the gha-run script for the cri-containerd tests. Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
|
/test |
amshinde
approved these changes
Feb 29, 2024
dborquez
requested changes
Feb 29, 2024
| @@ -48,7 +48,7 @@ function install_dependencies() { | |||
|
|
|||
| for github_dep in "${github_deps[@]}"; do | |||
| IFS=":" read -r -a dep <<< "${github_dep}" | |||
| install_${dep[0]} "${dep[1]}" | |||
| install_"${dep[0]}" "${dep[1]}" | |||
There was a problem hiding this comment.
Here you could enclose the entire word using double quotes:
Suggested change
| install_"${dep[0]}" "${dep[1]}" | |
| "install_${dep[0]}" "${dep[1]}" |
| @@ -35,7 +35,7 @@ function install_dependencies() { | |||
| sudo apt-get -y install "${system_deps[@]}" | |||
|
|
|||
| ensure_yq | |||
| ${repo_root_dir}/tests/install_go.sh -p -f | |||
| "${repo_root_dir}"/tests/install_go.sh -p -f | |||
There was a problem hiding this comment.
You could enclose the path and the command using double quotes, and call it with the source command (which is an alias for . )
Suggested change
| "${repo_root_dir}"/tests/install_go.sh -p -f | |
| . "${repo_root_dir}/tests/install_go.sh" -p -f |
This PR adds general variable fixes to gha-run script. Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
dborquez
approved these changes
Feb 29, 2024
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Cloud Hypervisor driver, integrated with the runtime-rs, as part of the cri-containerd tests.
Fixes #9181