agent:image: Refactor code to improve memory efficiency of image service #9325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Xynnn007 |
ChengyuZhu6
force-pushed
the
image_service
branch
2 times, most recently
from
a2d87ce
to
8d6a22b
Compare
|
/test |
stevenhorsman
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
I'm not a rust expert, but my understanding of this PR is that rather than have the lock().await.clone() on the singleton method which as you say will result in memory duplication, you've effectively moving the clone and lock down only when it's needed in functions, which should reduce the resources. Assuming that I've not missed the point - this makes sense to me. Thanks!
ChengyuZhu6
force-pushed
the
image_service
branch
from
8d6a22b
to
0fb008b
Compare
|
/test |
ChengyuZhu6
force-pushed
the
image_service
branch
7 times, most recently
from
098cfa9
to
dcad5ca
Compare
Currently, `.lock().await.clone()` results in `Option<ImageService>` being duplicated in memory with each call to `singleton()`. Consequently, if kata-agent receives numerous image pulling requests simultaneously, it will lead to the allocation of multiple `Option<ImageService>` instances in memory, thereby consuming additional memory resources. In image.rs, we introduce two public functions: `merge_bundle_oci()` and `init_image_service()`. These functions will encapsulate the operations on `IMAGE_SERVICE`, ensuring that its internal details remain hidden from external modules such as `rpc.rs`. Fixes: kata-containers#9225 -- part II Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com> Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6
force-pushed
the
image_service
branch
2 times, most recently
from
87fca3f
to
f47408f
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
.lock().await.clone()results inOption<ImageService>being duplicated in memory with each call tosingleton(). Consequently, if kata-agent receives numerous image pulling requests simultaneously, it will lead to the allocation of multipleOption<ImageService>instances in memory, thereby consuming additional memory resources.In image.rs, we introduce two public functions:
merge_bundle_oci()andinit_image_service(). These functions will encapsulate the operations onIMAGE_SERVICE, ensuring that its internal details remain hidden from external modules such asrpc.rs.Fixes: #9225 -- part II