Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Improve the kbs_k8s_delete function #9423

Merged
merged 1 commit into from Apr 10, 2024

Conversation

GabyCT
Copy link
Contributor

@GabyCT GabyCT commented Apr 5, 2024

This PR improves the kbs_k8s_delete function to verify that the resources were properly deleted for baremetal environments.

Fixes #9379

@GabyCT
Copy link
Contributor Author

GabyCT commented Apr 5, 2024

@wainersm besides the pod, do you want me to verify the deployment and the configmaps?

@GabyCT GabyCT changed the title tests: Improve the kbs_k8s_delete function WIP tests: Improve the kbs_k8s_delete function Apr 5, 2024
@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Apr 5, 2024
@wainersm
Copy link
Contributor

wainersm commented Apr 5, 2024

Hi @GabyCT ! Hey, thanks for working on it!

@wainersm besides the pod, do you want me to verify the deployment and the configmaps?

Notice that currently we only have support for the AKS ingress, but after the merge of #9273 we will have the nodeport too.

The AKS's ingress will install daemonsets too IIRC and we will need to check they were over. The nodeport ingress model will only deploy a service which I don't believe we should check it is deleted.

@GabyCT GabyCT added area/confidential-containers Issues related to confidential containers (see also CCv0 branch) no-backport-needed labels Apr 5, 2024
@GabyCT GabyCT changed the title WIP tests: Improve the kbs_k8s_delete function tests: Improve the kbs_k8s_delete function Apr 8, 2024
This PR improves the kbs_k8s_delete function to verify that the
resources were properly deleted for baremetal environments.

Fixes kata-containers#9379

Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
@GabyCT
Copy link
Contributor Author

GabyCT commented Apr 8, 2024

@wainersm I tested this PR on a baremetal environment and seems working as it verifies the nodeport and aks

kubectl get all -n coco-tenant
NAME                       READY   STATUS    RESTARTS   AGE
pod/kbs-757974bf88-gmz82   1/1     Running   0          63s

NAME                   TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)          AGE
service/kbs            ClusterIP   10.43.172.228   <none>        8080/TCP         24m
service/kbs-nodeport   NodePort    10.43.27.84     <none>        8080:30353/TCP   63s

NAME                  READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/kbs   1/1     1            1           24m

NAME                             DESIRED   CURRENT   READY   AGE
replicaset.apps/kbs-757974bf88   1         1         1       63s
replicaset.apps/kbs-5ff79d7849   0         0         0       24m

After running the PR, I verify that both nodeport and aks was gone on the baremetal

@GabyCT
Copy link
Contributor Author

GabyCT commented Apr 10, 2024

/test

@GabyCT GabyCT merged commit 08dcdc6 into kata-containers:main Apr 10, 2024
297 of 306 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/confidential-containers Issues related to confidential containers (see also CCv0 branch) ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: strengthen kbs_k8s_delete() for baremetal
6 participants