Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: Fix the issue with the "test_new_fs_manager" test #9457

Merged
merged 1 commit into from Apr 11, 2024

Conversation

justxuewei
Copy link
Member

@justxuewei justxuewei commented Apr 11, 2024

This patch introduces a one-time cpath to mitigate the cgroup residuals. It
might break the device cgroup merging rules when the cgroup has children.

Fixes: #9456

@katacontainersbot katacontainersbot added the size/large Task of significant size label Apr 11, 2024
@justxuewei justxuewei changed the title agent: Fix the "test_new_fs_manager" test agent: Fix the issue with the "test_new_fs_manager" test Apr 11, 2024
@justxuewei justxuewei changed the title agent: Fix the issue with the "test_new_fs_manager" test [WIP] agent: Fix the issue with the "test_new_fs_manager" test Apr 11, 2024
@justxuewei justxuewei force-pushed the fs_manager_tests branch 2 times, most recently from e1a44af to 5ae5b88 Compare April 11, 2024 10:01
@katacontainersbot katacontainersbot added size/medium Average sized task and removed size/large Task of significant size labels Apr 11, 2024
This patch introduces a one-time cpath to mitigate the cgroup residuals. It
might break the device cgroup merging rules when the cgroup has children.

Fixes: kata-containers#9456

Signed-off-by: Xuewei Niu <niuxuewei.nxw@antgroup.com>
@justxuewei justxuewei changed the title [WIP] agent: Fix the issue with the "test_new_fs_manager" test agent: Fix the issue with the "test_new_fs_manager" test Apr 11, 2024
@justxuewei
Copy link
Member Author

/test

Copy link
Member

@BbolroC BbolroC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @justxuewei for a quick fix.

@stevenhorsman
Copy link
Member

Let's get this merged to unblock other PRs!

@stevenhorsman stevenhorsman merged commit 6b2d655 into kata-containers:main Apr 11, 2024
302 of 343 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/medium Average sized task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test "test_new_fs_manager" failed
5 participants