-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update golang.org/x/net #9485
update golang.org/x/net #9485
Conversation
720862f
to
8edaa39
Compare
Hi @sparky005 - Thanks for the PR - it looks like there are a couple of failures here:
Thanks! |
updates golang.org/x/net to newer version that closes some reported vulnerabilities and security issues Fixes kata-containers#9486 Signed-off-by: Adil Sadik <sparky.005@gmail.com>
8edaa39
to
1c5ca0c
Compare
Thanks so much @stevenhorsman! Looks like I forgot to include some files in my original commit 😅. I've added them now but it looks like I'm still getting a failure, which looks like it may have been a kubelet issue? Not sure if that's related to my change or not. |
Probably not - our integration test are not super stable. Let me do a bit of babysitting on it and see if I can get enough passing |
/test |
Thanks @sparky005, it's seemed some cases still failed, let me retest them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @sparky005!
updates the update golang.org/x/net package. there are some reported vulnerabilities in this package and it's getting flagged by our internal security team.
Updated the packages as follows:
cd src/runtime/virtcontainers/pkg/cloud-hypervisor/client go get -u golang.org/x/net go mod tidy go mod vendor
Fixes #9486