Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: update cargo.lock #9518

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

danmihai1
Copy link
Member

Update Kata Agent's Cargo.lock after the recent changes to Cargo.toml.

Update Kata Agent's Cargo.lock after the recent changes to Cargo.toml.

Signed-off-by: Dan Mihai <dmihai@microsoft.com>
@katacontainersbot katacontainersbot added the size/small Small and simple task label Apr 18, 2024
@danmihai1
Copy link
Member Author

/test

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @danmihai1!

@danmihai1 danmihai1 requested a review from sprt April 19, 2024 15:36
@sprt
Copy link
Contributor

sprt commented Apr 19, 2024

How come the CI didn't catch this in the affected PR? What was it?

@danmihai1
Copy link
Member Author

How come the CI didn't catch this in the affected PR? What was it?

It was the last PR that changed Cargo.toml. Cargo.lock gets automatically re-generated if it's not good enough for the latest Cargo.toml, when cargo is building the Agent code, and I guess CI doesn't check that the file changed during build.

(I have seen similar issues in the past, when agent/Cargo.toml has changed - this is not a new type of issue for Kata)

Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo clippy doesn't generate further changes after this PR. Thanks @danmihai1 !

@gkurz gkurz merged commit 6ca0f09 into kata-containers:main Apr 22, 2024
304 of 311 checks passed
@danmihai1 danmihai1 deleted the danmihai1/agent-cargo-lock branch April 26, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/small Small and simple task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants