This repository has been archived by the owner on May 12, 2021. It is now read-only.
Fix logging of errors #26
Assignees
Comments
jodh-intel
added a commit
to jodh-intel/ksm-throttler
that referenced
this issue
Mar 22, 2018
Ensure all errors are logged using the `logrus.WithError()` API. The current `logrus.Error(err)` calls will result in log messages containing the following fields: ``` level=error msg="..." ``` Whereas using `logrus.WithError()` will result in the expected: ``` level=error error="..." ``` Fixes kata-containers#26. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
added a commit
to jodh-intel/ksm-throttler
that referenced
this issue
Mar 22, 2018
Ensure all errors are logged using the `logrus.WithError()` API. The current `logrus.Error(err)` calls will result in log messages containing the following fields: ``` level=error msg="..." ``` Whereas using `logrus.WithError()` will result in the expected: ``` level=error error="..." ``` Fixes kata-containers#26. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
added a commit
to jodh-intel/ksm-throttler
that referenced
this issue
Mar 22, 2018
Ensure all errors are logged using the `logrus.WithError()` API. The current `logrus.Error(err)` calls will result in log messages containing the following fields: ``` level=error msg="..." ``` Whereas using `logrus.WithError()` will result in the expected: ``` level=error error="..." ``` Fixes kata-containers#26. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
There are a few instances of logging errors using
logruswhich will result in alevel=errorfield, but noerror=field.The text was updated successfully, but these errors were encountered: