This repository has been archived by the owner on May 12, 2021. It is now read-only.
Require 2 pullapprove acks #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the pullapprove configuration to require two acks before a PR can be approved (for parity with the agent). Fixes kata-containers#6. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
For parity with the agent, disallow merging of RFC branches. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Change the pullapprove approval group to 'throttler'. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=======================================
Coverage 49.17% 49.17%
=======================================
Files 2 2
Lines 303 303
=======================================
Hits 149 149
Misses 115 115
Partials 39 39Continue to review full report at Codecov.
|
1 similar comment
|
LGTM |
1 similar comment
|
LGTM |
|
|
sameo
approved these changes
Dec 19, 2017
|
Hi @bergwolf - Where were you seeing the "invalid" message mentioned in #7 (comment) ? |
|
@jodh-intel It was reported by pullapprove.com in this PR. I'm not sure if it was just intermediate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.